Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions API implementation on view wallet page #49

Closed
scottdonaldau opened this issue Oct 30, 2017 · 3 comments
Closed

Transactions API implementation on view wallet page #49

scottdonaldau opened this issue Oct 30, 2017 · 3 comments

Comments

@scottdonaldau
Copy link
Contributor

Currently transactions do not appear on the view wallet page. Updates are required on the qrl node to enable this functionality.

@scottdonaldau
Copy link
Contributor Author

@jleni See https://github.com/theQRL/QRL/blob/master/qrl/services/PublicAPIService.py

Likely just need try/catch around these bits of GetObject

        if self.qrlnode.get_address_is_used(query):
            address_state = self.qrlnode.get_address_state(query)
            if address_state is not None:
                answer.found = True
                answer.address_state = address_state
                return answer

        transaction = self.qrlnode.get_transaction(query)
        if transaction is not None:
            answer.found = True
            answer.transaction = transaction.pbdata
            return answer

@scottdonaldau
Copy link
Contributor Author

When the above fix is implemented in next chain reset, The getAddressState API should respond with an array of transaction hashes.

@scottdonaldau
Copy link
Contributor Author

Transaction history is now available in view wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants