Feature search suggestion (enhancement) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shekhar12020
commented
Nov 5, 2015
shekhar12020
commented
- Added interface method in for search suggestion list in SearchEngine.java & implement that in YoutubeSearchEngine.java
- That method returns List of suggestion data.
- Also Added listener for SearchView SearchView.OnSuggestionListener in VideoItemListActivity.java
- I am only commiting 2 files as of now so that @medavox & I can resolve merge conflict in this two file.
…stion list. + Implemented SearchEngine Interface method in YoutubeSearchEngine class.
…ill return arraylist of string type data(suggestion).
+update searchEngine.java & YoutubeSearchEngine.java file. Conflicts: app/src/main/java/org/schabi/newpipe/SearchEngine.java app/src/main/java/org/schabi/newpipe/youtube/YoutubeSearchEngine.java
|
ok thanks |
theScrabi
added a commit
that referenced
this pull request
Nov 5, 2015
Feature search suggestion (enhancement)
|
I'll test it when I'm home. |
Atemu
pushed a commit
to Atemu/NewPipe
that referenced
this pull request
Aug 12, 2021
adjust descriptions (en+de) to match the fork
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.