Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the python version #4

Merged
merged 4 commits into from
Nov 7, 2016
Merged

the python version #4

merged 4 commits into from
Nov 7, 2016

Conversation

mikeaalv
Copy link
Contributor

I rewrite it from C++ file. It might not be perfect but it works at least for HIC059_30.hic and rabbit_rep1_30.hic

@nchernia
Copy link
Contributor

Thanks for all your work!

This isn't compatible with Python 2.7, could you try and fix the problems
so it runs successfully in both 2.7 and 3?

E.g. the line

return str(buf,encoding="utf-8", errors="strict")

becomes

return str(buf).encode("utf-8")

On Wed, Oct 26, 2016 at 6:02 AM, Yue Wu notifications@github.com wrote:

I rewrite it from C++ file. It might not be perfect but it works at least

for HIC059_30.hic and rabbit_rep1_30.hic

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

  • Merge remote-tracking branch 'theaidenlab/master'
  • Merge remote-tracking branch 'theaidenlab/master'
  • python version

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWiW3Fs8mx4qrTrGBxiAEvzD-uRcYhAks5q3tDdgaJpZM4KgvK5
.

Neva Cherniavsky Durand, Ph.D.
Staff Scientist, Aiden Lab
www.aidenlab.org

@nchernia nchernia merged commit 12f6279 into aidenlab:master Nov 7, 2016
sa501428 added a commit that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants