Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file name palindrome.test.js should be Palindrome.test.js to follow UpperCamelCase #1143

Closed
AbdulAhadKhan0308 opened this issue Oct 7, 2022 · 2 comments · Fixed by #1159
Closed

file name palindrome.test.js should be Palindrome.test.js to follow UpperCamelCase #1143

AbdulAhadKhan0308 opened this issue Oct 7, 2022 · 2 comments · Fixed by #1159
Labels
chore General improvement trivial

Comments

@AbdulAhadKhan0308
Copy link
Contributor

file is at Recursive/test/palindrome.test.js
@AbdulAhadKhan0308 AbdulAhadKhan0308 changed the title file name palindrome.test.js should be Palindorme.test.js to follow UpperCamelCase file name palindrome.test.js should be Palindrome.test.js to follow UpperCamelCase Oct 7, 2022
@appgurueu appgurueu added chore General improvement trivial labels Oct 7, 2022
@appgurueu
Copy link
Collaborator

appgurueu commented Oct 7, 2022 •
edited
Loading

Makes me question our contribution guideline. Usually file name conventions dictate lower snake case; UpperCamelCase is reserved for classes. Files exporting single functions should probably not be using UpperCamelCase but rather lowerCamelCase (like the funcs) or lower_snake_case.

@raklaptudirm
Copy link
Member

This repository uses UpperCamelCase for all JavaScript files.

@chapmanm3 chapmanm3 mentioned this issue Oct 10, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore General improvement trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Code Smell] Rename palindrome test to Palindrome to follow standard chapmanm3/JavaScriptAlgos
3 participants
@appgurueu @raklaptudirm @AbdulAhadKhan0308