Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked List implementation is unsound #539

Closed
CordlessCoder opened this issue Oct 3, 2023 · 3 comments
Closed

Linked List implementation is unsound #539

CordlessCoder opened this issue Oct 3, 2023 · 3 comments
Labels

Comments

@CordlessCoder
Copy link

CordlessCoder commented Oct 3, 2023

  • get* methods conjure 'static references that can be held beyond the lifetime of the list, which is unsound
  • get* methods take a mutable reference, which is unnecessary
  • no get_mut methods
  • incorrectly uses i32 for indexing instead of usize
@CordlessCoder
Copy link
Author

I will attempt to address these in a PR

Copy link

github-actions bot commented Nov 3, 2023

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 3, 2023
Copy link

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant