Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter doesn't work after empty list #49

Closed
steveroseik opened this issue Dec 31, 2023 · 3 comments
Closed

Search filter doesn't work after empty list #49

steveroseik opened this issue Dec 31, 2023 · 3 comments

Comments

@steveroseik
Copy link

Describe the bug
When you use the search textfield to filter the list, if you reach a dead end and your keyword doesn't correspond to items.
You then have to delete the whole keyword instead of just fixing your keyword typo in order to get the filter to work again.

for example:

List:

  • yorkshire
  • bulldog

if your keyword is "yorf": result is 0 items
then if you fix the keyword to "yor": result is still 0 items
until the you clear all the text and type "y": result 1 item

To Reproduce
Steps to reproduce the behavior:

Create a list and use search filters on it

Expected behavior
expected to have the keyword filter fire for each change in textfield

@bradfrizzell
Copy link

Plus one on this!

@bradfrizzell
Copy link

The bug is this line - it shouldn't be in this if block. https://github.com/TheAlphamerc/filterlist/blob/master/lib/src/filter_list_widget.dart#L191

@TheAlphamerc
Copy link
Owner

This is fixed in version 1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants