Method anasol missing from API for PhysicsModel

[keileg]

``In the IOT physical model, the physics based model is assumed to have a function anasol

Costa/test/ifem-heateqn/published/iot-physical.py

Line 28 in d5b9aa2

state = pbm.anasol(params)['primary']

This is however not specified in API for PhysicsModels

Costa/Costa/api.py

Line 16 in d5b9aa2

class PhysicsModel(ABC):

I tried to find the implied method signature from the IFEM repository, but got lost in the class structure in that repo. Is it correct that the method implements something like

def anasol(params: Dict[str, Union[float, List[float]]]) -> Dict[str, np.ndarray]):
    return {'primary': np.ndarray([values_given_information_from_params])

[akva2]

that is correct yes, it's a dict with [string : array-like] entries.

the name of the entries are a convention thing, you can do whatever you want as such, but in IFEM-CoSTA we use 'primary' and 'secondary_(x|y|z)'.

it's not in the PhysicsModel because it's not strictly necessary as such, just convenient for testing. I guess @TheBB forgot and stuck in in there without considering whether or not we should really require it.

[keileg]

Yes, a hack like that was mentioned.

Thanks a lot, I will adjust my code accordingly.