Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3.0] typings not found #206

Closed
efstathiosntonas opened this issue Feb 24, 2022 · 5 comments · Fixed by #207
Closed

[7.3.0] typings not found #206

efstathiosntonas opened this issue Feb 24, 2022 · 5 comments · Fixed by #207
Labels

Comments

@efstathiosntonas
Copy link
Contributor

🐛 Bug Report

After upgrading to 7.3.0 I get no typings found, tried installing @types/react-native-fbsdk-next to no avail so I guess there's something wrong in the typings export during build.

exact error is: TS7016: Could not find a declaration file for module 'react-native-fbsdk-next'.

To Reproduce

just install 7.3.0. Prior opening issue I deleted node_modules and re-installed but it won't fix.

Expected Behavior

Typings should be available

Code Example

Environment

Typescript 4.5.4

@mikehardy
Copy link
Collaborator

Oh no! Performing triage now, there's only one feature in the release but it's a big one and it did alter package inclusion rules #205 - will pop out a 7.3.1 as soon as I figure out what happened + repair

@mikehardy
Copy link
Collaborator

Strange (to me) interaction between the ./tsconfig.json file and the new plugin/tsconfig.json where the new plugin one sets an outdir of src and the main typescript transpile is picking that up and putting things one sub-directory down now, in in src

So, if I update <my app dir>/node_modules/react-native-fbsdk-next/package.json such that it's types entry is now

  "types": "lib/typescript/src/index.d.ts",

...in place of

  "types": "lib/typescript/index.d.ts",

...then it works for me

@efstathiosntonas (or anyone else watching) if you confirm that also works for you I'll publish that change

@mikehardy mikehardy added the needs more info waiting on original poster to provide details label Feb 24, 2022
@efstathiosntonas
Copy link
Contributor Author

efstathiosntonas commented Feb 24, 2022

@mikehardy I confirm it's working, thanks.

ps. was about to say it doesn't work, had to restart the crappy Webstorm for the error to go away.... The path is CORRECT Webstorm get your sh*t together

@mikehardy
Copy link
Collaborator

haha VSCode for the win! (I'm kidding, everyone should use the editor they want and I have to reload VSCode sometimes for type defs too)

Thanks so much for noting this, reporting it, and helping test. PR merging + release in a moment

@mikehardy mikehardy removed the needs more info waiting on original poster to provide details label Feb 24, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 7.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants