Added ec2 tags to volumes and snapshots

[echupriyanov]

Now rexray only lists volumes and snapshot with specific tag/value.
Tag is defined in drivers/storage/ec2.go driver:

const rexrayTag = "rexraySet»

Tag value can be defined in rexray/config.yml:

aws:
  accessKey: ...
  secretKey: ...
  region: ...
  rexrayTag: rexray

Default value is rexray.

[clintkitson]

Thanks for the work here!

1. It looks like you missed a tag
   https://github.com/echupriyanov/rexray/blob/ec2tags/drivers/storage/ec2/ec2.go#L888-L894

2. To implement this we would want to make sure it doesn't by default impact the existing functionality unless configured. Can you add if statements for the new tag field/filter to make sure it is only included if defined?

[echupriyanov]

24 февр. 2016 г., в 20:06, Clinton Kitson notifications@github.com написал(а):

Thanks for the work here!

1. It looks like you missed a tag
   https://github.com/echupriyanov/rexray/blob/ec2tags/drivers/storage/ec2/ec2.go#L888-L894 https://github.com/echupriyanov/rexray/blob/ec2tags/drivers/storage/ec2/ec2.go#L888-L894
2. To implement this we would want to make sure it doesn't by default impact the existing functionality unless configured. Can you add if statements for the new tag field/filter to make sure it is only included if defined?

Sure. Will update PR

[echupriyanov]

While testing this PR I’ve hit another issue:

root@swarm-node-06a:~# /tmp/rexray snapshot copy --snapshotid=snap-28a67508 --destinationsnapshotname=t3s2
FATA[0001] Get /?AWSAccessKeyId=AKIAasfdsafsasdfasVQ&Action=CopySnapshot&Description=%5BCopied+snap-28a67508+from+eu-west-1%5D&Signature=j9UMO%2Bl%sdfdfdsfsadfsdafF2cVWs%3D&SignatureMethod=HmacSHA256&SignatureVersion=2&SourceRegion=eu-west-1&SourceSnapshotId=snap-28a67508&Timestamp=2016-02-24T18%3A12%3A26Z&Version=2015-03-01: unsupported protocol scheme "" 

Where:

root@swarm-node-06a:~# /tmp/rexray version
Binary: /tmp/rexray
SemVer: 0.3.2-rc3
OsArch: Linux-x86_64
Branch: v0.3.2-rc3
Commit: 8898ba495befeec585aeaf4489d1f96563156382
Formed: Tue, 23 Feb 2016 18:20:11 UTC
root@swarm-node-06a:~# 

Will look into it tomorrow

[clintkitson]

Seen this before. I believe it was related to the region not supporting the API scheme that was specified.

[echupriyanov]

Just to note, I've update PR with default (no rexrayTag in config.yml) fallback to existing functionality.

[akutz]

Hi @clintonskitson,

Is this targeted for 0.3.2?

[clintkitson]

@akutz I am going to review this one now.

[akutz]

Hi @clintonskitson,

Let me restate my question - is this a bugfix or some required enhancement? If not it should be pushed to 0.4 so 0.3.2 can be released ASAP.

[clintkitson]

This is an enhancement, so let's move with 0.3.2.

[akutz]

Hi @clintonskitson,

That's fine, but has it been on the docket for a while? Unless it's required to accommodate some external thing it should be punted to 0.4. We're in the release train, and we need to minimize churn. Only bug fixes should be included at this time.

[clintkitson]

Agreed @akutz

[clintkitson]

@echupriyanov This actually tests out well, thank you for the work. Can you take a swing at updating the EC2 docs with the updated tag to make this PR complete?

[echupriyanov]

@clintonskitson Sure. Will do it tomorrow morning.

[echupriyanov]

Added rexrayTag description to user-guide/storage-providers section

[clintkitson]

@echupriyanov Nice job here, well done.

[clintkitson]

#358