Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow APACHE_DOCUMENT_ROOT to be set outside of /var/www/html #113

Closed
ghost opened this issue Jan 14, 2019 · 2 comments
Closed

Allow APACHE_DOCUMENT_ROOT to be set outside of /var/www/html #113

ghost opened this issue Jan 14, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 14, 2019

Expected Behavior

I think that APACHE_DOCUMENT_ROOT should be allowed to be set outside of /var/www/html. Since regular Apache configuration allows it.

Current Behavior

Currently you can only set a subfolder of /var/www/html:
https://github.com/thecodingmachine/docker-images-php/blob/v2/Dockerfile.7.2.slim.apache#L77-L80

Possible Solution

The solution would be to set the default to /var/www/html and if the variable is set override the entirety of the default instead. Problem is that I don't see a way that keeps backward compatibility without introducing a secondary variable.

Context

The reason for me requesting this is because on my development environment I'm using Docker in Docker setup to control my environment from inside. When using docker-compose you'd want to have the path be the exact same as on your host system. This allows you to docker-compose ps your docker system.

@moufmouf
Copy link
Member

moufmouf commented Dec 3, 2019

This was a BC break change so I waited for v3 images to release this. This is implemented in the new v3 image.
See 3f0c4f4#diff-bf5448a20dea5f94057341c991830bed

@moufmouf moufmouf closed this as completed Dec 3, 2019
@ghost
Copy link
Author

ghost commented Dec 4, 2019

Thank you @moufmouf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant