Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update macros #12

Closed
TheComamba opened this issue Apr 22, 2023 · 0 comments · Fixed by #16
Closed

Properly update macros #12

TheComamba opened this issue Apr 22, 2023 · 0 comments · Fixed by #16
Labels
feature New feature or request

Comments

@TheComamba
Copy link
Owner

TheComamba commented Apr 22, 2023

One problem is that actors can have the same name. But maybe that's an edge case that we simply don't service.
Alternatively we work with the actor id. That's probably much easier.

Acceptance criteria:
Create a macro whenever new actor becomes (!) unkenny.
Delete the macro when that actor becomes un-unkenny.
Delete the macro when that actor is deleted.
Re-create macro if the actor name changes.

Solution 1:
Hook actions into the events above.

Solution 2:
Write an updateUnKennyMacros function that loops over all actors and macros and synchronises them.

Solution 3:
Do both, calling updateUnKennyMacros on init hook.

@TheComamba TheComamba added the feature New feature or request label Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant