Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile without root permissions in runtime #24

Closed
JuniorJPDJ opened this issue Feb 17, 2021 · 4 comments · Fixed by #25
Closed

Dockerfile without root permissions in runtime #24

JuniorJPDJ opened this issue Feb 17, 2021 · 4 comments · Fixed by #25

Comments

@JuniorJPDJ
Copy link
Contributor

Hi!
Your Dockerfile seems to use root user in runtime, that's not safe :<
Could you guys please fix this?

@TheConnMan
Copy link
Owner

@JuniorJPDJ do you have a recommendation on what change I should make?

@JuniorJPDJ
Copy link
Contributor Author

You probably should play with files permissions and set USER inside Dockerfile.

@TheConnMan
Copy link
Owner

Would you be willing to push a PR to help with the fix? I'll gladly review and merge it in.

@JuniorJPDJ
Copy link
Contributor Author

I did ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants