Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Added styling to make a responsive Feeds page, resolves #803 - cherry pick of pr 831 #857

Closed
wants to merge 2 commits into from

Conversation

ArkadiK94
Copy link
Contributor

@ArkadiK94 ArkadiK94 commented Jun 11, 2024

Fixes Issue

Closes #803

Changes proposed

  • Updated styling and removed unnecessary styling components to make Feeds page responsive
  • I noticed that a lot of the Styled components affect the other components on Explore/Blogs pages
  • Hence why I had to use a lot of the prop styling to work around
  • I gave the feed a 1 column design when in mobile/tablet range and as the screen grows fits a 2 column layout

Screenshots

image

image

image

image

image

Note to reviewers

done by @alvarotorrestx
cherry pick of pr #831

Code of Conduct

  • By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

Copy link

render bot commented Jun 11, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

🌟 Welcome to the community 🌟

  • If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
  • You should join our Discord chat and our GitHub Organisation.
  • We help and encourage each other to contribute to open source little and often 😄.
  • Any questions let us know.

@ArkadiK94
Copy link
Contributor Author

@alvarotorrestx Thanks for contributing, as you saw there are some comments.
Before the comments, notice the next important note:

The dev branch is a new branch which was changed due to repo technical errors

What you need to do:
Step one in github:
Go to local repo
Click "Synk fork"
Click Discard Commits/Changes

Step two in local editor:
You will notice a number of commits that it wants to push let's call it X
In terminal:
git reset HEAD~X
git pull

If you would like to solve the comments you should do them in this branch:
gh pr checkout 857

Sorry for this scenario, it is not something that happens often.

@ArkadiK94
Copy link
Contributor Author

@alvarotorrestx

the feeds in this screen make them a little bit less wider (around by 100px)

image

here make the search bar half of the current wide

image

80%-85% wide so we will have in the sides some blank space

image

too much wider , do it 65%-70% approximately

image

Copy link
Contributor Author

@ArkadiK94 ArkadiK94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comments from prev pr

@ArkadiK94
Copy link
Contributor Author

@alvarotorrestx hi, how is it going?

@alvarotorrestx
Copy link
Contributor

@ArkadiK94 good, I've just been behind due to school work. I should have a PR in tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Responsive-Web] Irresponsive Elements on mobile screen
2 participants