Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new fine-grained enum for build_cast #439

Open
marcospb19 opened this issue Sep 4, 2023 · 1 comment
Open

Create new fine-grained enum for build_cast #439

marcospb19 opened this issue Sep 4, 2023 · 1 comment
Labels
enhancement

Comments

@marcospb19
Copy link

marcospb19 commented Sep 4, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
When running build_cast, I'm unsure of what options are available.

Describe the solution you'd like
build_cast should accept an enum that is a subset of InstructionOpcode, such subset should only contain valid options for build_cast.

Describe possible drawbacks to your solution
Might be painful to maintain, especially between different versions.
@marcospb19 marcospb19 changed the title Create new enum types for operations Create new fine-grained enum for build_cast Sep 4, 2023
@EricLBuehler
Copy link
Contributor

Maybe this can be done with a macro on InstructionOpcode that adds the variants in, say, CastOpcode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheDan64 @marcospb19 @EricLBuehler