Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with parsing crate name from Cargo.toml (need to s/-/_/) #15

Closed
thedodd opened this issue Aug 27, 2020 · 3 comments · Fixed by #17
Closed

Bug with parsing crate name from Cargo.toml (need to s/-/_/) #15

thedodd opened this issue Aug 27, 2020 · 3 comments · Fixed by #17
Assignees
@thedodd
Labels
bug Something isn't working
Milestone
0.2.0 | QOL, clea...

Comments

@thedodd
Copy link
Member

thedodd commented Aug 27, 2020

There may be some other corner cases here. Review the Cargo docs, and make sure we process the crate names the same way that Cargo does. Unless anyone else has a better option.

Also, thanks @MartinKavik for the report.
@thedodd thedodd added bug Something isn't working core labels Aug 27, 2020
@thedodd thedodd self-assigned this Aug 27, 2020
thedodd added a commit that referenced this issue Aug 27, 2020
@thedodd
Process crate names as Cargo does & use index.html as default target.
f4d5c0c 
closes #15
closes #16
@thedodd thedodd mentioned this issue Aug 27, 2020
Merged
@MartinKavik
Copy link
Contributor

image

@thedodd
Copy link
Member Author

thedodd commented Aug 30, 2020

Hmm if you are still seeing this on 0.3, then it is apparently a regression ... though I am definitely processing the crate names properly. Will review again soon.

@thedodd thedodd reopened this Aug 30, 2020
@thedodd
Copy link
Member Author

thedodd commented Aug 30, 2020

Ugh already found the issue. Definitely a regression. I'll pin this down with some tests to ensure we don't get a regression in this again.

thedodd added a commit that referenced this issue Aug 30, 2020
@thedodd
Fix a small regression in resolving cargo build's output WASM.
d2a51e7 
closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedodd thedodd

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0 | QOL, clean-up & multi-project...
Development

Successfully merging a pull request may close this issue.

Process crate names as Cargo does & use index.html as default target. trunk-rs/trunk
2 participants
@thedodd @MartinKavik