-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #21188 - Add rubygem-foreman_datacenter package #2336
Conversation
[test rpm] |
3 similar comments
[test rpm] |
[test rpm] |
[test rpm] |
(fails because nightly foreman is broken) |
Probably needs #2355 because I added packages to incorrect comps. |
This is green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekohl Looks good to me, I see foreman >= 1.16
, is this meant for 1.16, 1.17 and nightly?
@dLobatog I think the various dependencies weren't included in the older releases so I'd be fine with just nightly for now. |
I'm not sure if the current code of this plugin works with current develop. |
I rebased the branch, bumped to newest plugin release 1.20.0 and tested successfully. |
Looking at what I have here it looks like it should be regenerated with the current template anyway. Given the state of the plugin I've been reluctant to put in more effort. It's developed against released versions instead of nightly. This is not how we work in packaging. |
Any updates on this PR? Should I close it? |
From my side I am fine with closing. I have no actual need for packages at the moment (read no costumer using it) and with the reason @ekohl has given I do not promote it (so likely also no future customer). If something changes, I will open a new PR. |
No description provided.