Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21188 - Add rubygem-foreman_datacenter package #2336

Closed
wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 3, 2018

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Apr 3, 2018

[test rpm]

3 similar comments
@ekohl
Copy link
Member Author

ekohl commented Apr 3, 2018

[test rpm]

@ekohl
Copy link
Member Author

ekohl commented Apr 3, 2018

[test rpm]

@ekohl
Copy link
Member Author

ekohl commented Apr 4, 2018

[test rpm]

@ekohl
Copy link
Member Author

ekohl commented Apr 4, 2018

(fails because nightly foreman is broken)

@ekohl
Copy link
Member Author

ekohl commented Apr 5, 2018

Probably needs #2355 because I added packages to incorrect comps.
[test rpm]

@ekohl ekohl changed the title Add rubygem-foreman_datacenter package Fixes #21188 - Add rubygem-foreman_datacenter package Apr 5, 2018
@ekohl
Copy link
Member Author

ekohl commented Apr 5, 2018

This is green now.

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl Looks good to me, I see foreman >= 1.16 , is this meant for 1.16, 1.17 and nightly?

@ekohl
Copy link
Member Author

ekohl commented Apr 30, 2018

@dLobatog I think the various dependencies weren't included in the older releases so I'd be fine with just nightly for now.

@mmoll
Copy link

mmoll commented Apr 30, 2018

I'm not sure if the current code of this plugin works with current develop.

@dgoetz
Copy link
Member

dgoetz commented Mar 8, 2019

I rebased the branch, bumped to newest plugin release 1.20.0 and tested successfully.
You can find it in my branch https://github.com/dgoetz/foreman-packaging/tree/rpm/datacenter.
@ekohl: Do you want to process or should I create a new pull request based on my branch?

@ekohl
Copy link
Member Author

ekohl commented Mar 18, 2019

Looking at what I have here it looks like it should be regenerated with the current template anyway. Given the state of the plugin I've been reluctant to put in more effort. It's developed against released versions instead of nightly. This is not how we work in packaging.

@ehelms
Copy link
Member

ehelms commented Sep 18, 2019

Any updates on this PR? Should I close it?

@dgoetz
Copy link
Member

dgoetz commented Sep 18, 2019

From my side I am fine with closing. I have no actual need for packages at the moment (read no costumer using it) and with the reason @ekohl has given I do not promote it (so likely also no future customer). If something changes, I will open a new PR.

@ehelms ehelms closed this Sep 19, 2019
@ekohl ekohl deleted the rpm/add-fm-dc branch July 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants