-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rubygem-foreman_probing_core package #2772
Add rubygem-foreman_probing_core package #2772
Conversation
208b7dc
to
b5d0e34
Compare
b5d0e34
to
64bc80e
Compare
packages/plugins/rubygem-foreman_probing_core/rubygem-foreman_probing_core.spec
Outdated
Show resolved
Hide resolved
64bc80e
to
730d938
Compare
730d938
to
31e0932
Compare
I have changed the spec like requested. Is the additional provides in foreman_probing_core correct or should I better change the require in smart-proxy-probing? Without it provides and requires would not match one package being scl and the other non-scl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct now in terms of SCL/non-SCL
This needs a rebase please |
Add rubygem-ruby-nmap package Add rubygem-rprogram package
31e0932
to
4f72858
Compare
@evgeni any idea why this is failing? it looks related to your change in the job. |
@ekohl actually, yes ;) |
@ekohl theforeman/foreman-infra#931 should fix it |
[test rpm] |
1 similar comment
[test rpm] |
|
Add also rubygem-ruby-nmap and rubygem-rprogram package as dependency.
This is a Smart Proxy Dynflow Core plugin so I hope I used the correct template as start.
For plugin updates, please indicate which repos this should be built into:
See Foreman's plugin maintainer documentation for more information.