Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubygem-foreman_probing_core package #2772

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

dgoetz
Copy link
Member

@dgoetz dgoetz commented Jul 19, 2018

Add also rubygem-ruby-nmap and rubygem-rprogram package as dependency.
This is a Smart Proxy Dynflow Core plugin so I hope I used the correct template as start.

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.19
  • 1.18
  • 1.17

See Foreman's plugin maintainer documentation for more information.


@dgoetz
Copy link
Member Author

dgoetz commented Jul 24, 2018

I have changed the spec like requested.

Is the additional provides in foreman_probing_core correct or should I better change the require in smart-proxy-probing? Without it provides and requires would not match one package being scl and the other non-scl.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct now in terms of SCL/non-SCL

@ehelms
Copy link
Member

ehelms commented Oct 10, 2018

This needs a rebase please

Add rubygem-ruby-nmap package
Add rubygem-rprogram package
@ekohl
Copy link
Member

ekohl commented Feb 6, 2019

@evgeni any idea why this is failing? it looks related to your change in the job.

@evgeni
Copy link
Member

evgeni commented Feb 6, 2019

@ekohl actually, yes ;)
It's failing because I was stupid ;)
PR incoming :)

@evgeni
Copy link
Member

evgeni commented Feb 6, 2019

@ekohl theforeman/foreman-infra#931 should fix it

@evgeni
Copy link
Member

evgeni commented Feb 8, 2019

[test rpm]

1 similar comment
@evgeni
Copy link
Member

evgeni commented Feb 25, 2019

[test rpm]

@evgeni
Copy link
Member

evgeni commented Feb 25, 2019

% koji add-pkg foreman-plugins-nightly-rhel7 tfm-rubygem-foreman_probing_core --owner=kojiadm
Adding 1 packages to tag foreman-plugins-nightly-rhel7
% koji add-pkg foreman-plugins-nightly-rhel7 tfm-rubygem-rprogram --owner=kojiadm            
Adding 1 packages to tag foreman-plugins-nightly-rhel7
% koji add-pkg foreman-plugins-nightly-rhel7 tfm-rubygem-ruby-nmap --owner=kojiadm 
Adding 1 packages to tag foreman-plugins-nightly-rhel7

@evgeni evgeni merged commit 986d988 into theforeman:rpm/develop Feb 25, 2019
@evgeni evgeni mentioned this pull request Feb 25, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants