drop node dependencies which are unused for building #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
changed the title
|
[test packaging] |
evgeni
force-pushed
the
deb/develop-speedup-simple
branch
from
29e7189
to
0499778
Compare
|
Depends on theforeman/foreman#8731 |
evgeni
force-pushed
the
deb/develop-speedup-simple
branch
from
0499778
to
c084b60
Compare
evgeni
changed the title
|
all my changes to core have been merged, so this is now just a simple "call a script and carry on" PR 😹 |
|
one thing this also should help with, is plugin building. |
ekohl
reviewed
Aug 24, 2021
| @@ -16,6 +16,7 @@ build: | |||
| /bin/rm -f bundler.d/test.rb bundler.d/development.rb | |||
| /bin/sed -i '2i gem "puma-status"' bundler.d/service.rb | |||
| BUNDLE_BUILD__SASSC=--disable-march-tune-native BUNDLE_RETRY=5 BUNDLE_JOBS=4 /usr/bin/bundle package | |||
| /usr/bin/python script/filter-package-json.py | |||
There was a problem hiding this comment.
It's not executable with a shebang?
There was a problem hiding this comment.
It's not (and the shebang is using py3, which we don't install by default -- the script works with py2 and 3 identically)
ekohl
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.