Fixes #12970 - Package patternfly-sass

[dLobatog]

• Add patternfly-sass
• Update bootstrap-sass to 3.3.6 - Refs #12970 - Update bootstrap-sass to 3.3.6 for Patternfly #951
• Add autoprefixer-rails 5.2.1.3 - Refs #12970 - Package autoprefixer-rails 5.2.1.3 for Patternfly #950
• Update sprockets-rails to 2.3.3 - Refs #12970 - sprockets-rails 2.3.3 for Patternfly #949
• Add sprockets 3 (at least). - Refs #12970 - Add sprockets 3.5.2 for Patternfly #954
• Add ejs 1.1 for sprockets 3 - Refs #12970 - ejs 1.1.1 for Patternfly sprockets #965
• Add sass-rails 5.0, ror41 max version is 4.0.3 - Refs #12970 - Package sass-rails 5 for Patternfly #961
• Add font-awesome-sass - Fixes #12969 - font-awesome-sass package for Patternfly #943
• Add sass 3.4.19 - Refs #12790 - Add sass 3.4.19 for Patternfly #966
• Update foreman.spec to depend on the aforementioned packages
• Build a temporary repository with this
  patternfly.zip

cc - theforeman/foreman#294

[domcleal]

ASL 2.0 in a spec file

[domcleal]

1. as per Fixes #12969 - font-awesome-sass package for Patternfly #943, missing comps/ and rel-eng/ updates. Please rebase first to avoid a conflict.
2. missing runtime requires
3. missing relevant versions of sass and bootstrap-sass, they'd also need updating

[domcleal]

It looks like you're updating a lot of packages to fully implement the changes in #4629, so you might find this easier in one PR and/or with a temporary repo (e.g. using mockchain or copr) to show the changes work together - including the changes to foreman/foreman.spec.

[dLobatog]

It looks like I have to:

• Add patternfly-sass (done?)
• Update bootstrap-sass to 3.3.6
• Add autoprefixer-rails 5.2.1.3
• Update sprockets-rails to 2.3.3 (at least). 2.2.4 is the maximum version in the ror41 SCL, would it be worth it to submit changes there directly?
• Add sprockets 3 (at least). The maximum version on ror41 is 2.12.3.
• Add sass-rails 5.0, ror41 max version is 4.0.3
• Add font-awesome-sass - Fixes #12969 - font-awesome-sass package for Patternfly #943
• Update foreman.spec to depend on the aforementioned packages

I think that would be it, I'll add it to the original comment as a check list. @domcleal, you said you would prefer all of these changes in this PR, plus a copr with the packages then? Most of the items in the list above don't necessarily have to rely on one another so they could be merged independently.

[domcleal]

Update sprockets-rails to 2.3.3 (at least). 2.2.4 is the maximum version in the ror41 SCL, would it be worth it to submit changes there directly?

I doubt very much that you could get this changed in the rh-ror41 SCL, since it's a rebuild of a Red Hat product, so the "upstream" has a policy of no rebases.

I don't mind if this is in one PR or many, but I think the series of packages will need to be chainbuilt to prove that it all works together (mockchain with the configs in mock/ and SRPMs from tito build --srpm --test should be easy).

[domcleal]

Don't worry about Redmine tickets for each change too, it's not necessary here - just more admin work.

[domcleal]

missing the main package?

[dLobatog]

It's on line 75

[domcleal]

Please let me know when you have a set of packages tested together. It should be possible to use mockchain with the configs provided in the mock/ directory to build all of these packages in sequence and then the SRPM of foreman.

At the moment they're also going to have quite a few merge conflicts in foreman.spec, which'll make it a bit trickier.

[dLobatog]

I'm building this temporary repo now with:

for dir in rubygem-*; do 
(cd "$dir" && 
tito build --srpm --test\
 --builder tito.builder.MockBuilder\
 --arg mock_config_dir=mock/ --arg mock=el7-scl); 
done

mockchain -r el7-scl -l /tmp/patternfly/ --recurse /tmp/tito/*.src.rpm

[dLobatog]

Duh, it looks like rubygem(ejs) is not packaged. I'll take it from https://github.com/domcleal/sclo-ror42/tree/master/rubygem-ejs

[dLobatog]

For the record I'm keeping a branch with all of the changes here

If that builds properly (currently it doesn't), I'll port the relevant changes to every PR on the checklist.

[dLobatog]

Success! I'll start updating the PRs with the few changes I made, basically dLobatog@ad77506

[dLobatog]

Find the output of mockchain at patternfly.zip

[domcleal]

You should then be able to build foreman itself on top of that. Get an SRPM with the latest develop code with cd foreman && tito release --scratch --arg jenkins_job=test_develop koji-foreman-nightly --dry-run, then run it on your existing chain repo.

[dLobatog]

It's not building now because rubygem(sass) from ror41 is also too old.

Error: Package: tfm-rubygem-patternfly-sass-2.8.0-1.git.0.7154183.el7.centos.noarch (local_build_repo)
           Requires: rh-ror41-rubygem(sass) >= 3.4.15
           Installing: rh-ror41-rubygem-sass-3.3.8-1.el7.centos.noarch (scl-ror)
               rh-ror41-rubygem(sass) = 3.3.8

I'll bundle it too.

[dLobatog]

@domcleal I built foreman with mockchain + the other packages. Find the zip here: patternfly.zip

I worked out of this branch https://github.com/dLobatog/foreman-packaging/commits/rpm/patternfly-all then split it all in all the various PRs you can see here.

[domcleal]

Thanks, all looks good except for one comment on sprockets I think it was. I'm working through the PRs in this order to match the build order:

• rubygem-autoprefixer-rails
• rubygem-bootstrap-sass
• rubygem-ejs
• rubygem-font-awesome-sass
• rubygem-patternfly-sass
• rubygem-sass
• rubygem-sass-rails
• rubygem-sprockets
• rubygem-sprockets-rails

Once the previous one's merged the next is almost certainly going to need a rebase. Don't worry about rebasing all of them as it'll just generate PR test load.

[domcleal]

Could you rebase this please @dLobatog?

[dLobatog]

@domcleal Rebased, it only conflicted on foreman.spec w/ autoprefixer-rails

[domcleal]

Thanks @dLobatog, merged and building.

[domcleal]

The core Foreman package has been rebuilt and passed tests. Thanks for the updates @dLobatog!