-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #25833: increase hover delay for menu items. #6405
Conversation
Issues: #25833 |
[test foreman] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone have any thoughts on this?
Umm, what? |
I suppose we could, I just wasn't sure what the best value was so as to not get the bug reopened. @Rohoover do you have any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about 50 instead of 100?
Hey, I tried this out on the dogfood server and I personally didn't experience any miss-clicks from delay. It does seem a bit longer than expected in the video above. |
I think the dogfood server would have the standard version of what is in master (oops, develop 🤦♂️). You can try this out on my sandbox if you want, just message me and I'll give you the details. |
Story book?
…On Wed, Jan 16, 2019, 12:43 Walden Raines ***@***.*** wrote:
Hey, I tried this out on the dogfood server and I personally didn't
experience any miss-clicks from delay. It does seem a bit longer than
expected in the video above.
I think the dogfood server would have the standard version of what is in
master (oops, develop 🤦♂️). You can try this out on my sandbox if you
want, just message me and I'll give you the details.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6405 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOxw5igJ26tpS_jcA26HrdbEFtuHDdks5vD2TUgaJpZM4Z6G6y>
.
|
[test foreman] perhaps you'll need to rebase |
[test katello] |
Is this a known issue in travis?
|
Ensure menu items don't close too quickly by increasing the delay. https://projects.theforeman.org/issues/25833
https://community.theforeman.org/t/can-we-drop-node-js-6-14-from-travis-javascript-test-matrix/12737
…On Wed, Feb 20, 2019 at 5:43 PM Walden Raines ***@***.***> wrote:
Is this a known issue in travis?
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out
of memory
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6405 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOxxykShzI6HqnNqtfdBRchk72mNJVks5vPW0lgaJpZM4Z6G6y>
.
|
[test foreman] |
whats the status of this pr? |
Got a chance to test the new delay. I like it quite a bit! Nice job! |
Should just need to be reviewed/merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better experience. For things like that I'd like to have more opinions, but given we have ack from @Rohoover and how complicated the patch or the delay adjustment is, I'll go ahead and merge.
Thanks @waldenraines, merging!
I can barely tell what is happening in the gif, can you explain it please? |
Yeah sorry, the Audits page in not loading - is blank, the component is rendered, but not visible. I do not know why, but i went commit by commit and this is the first where it happens for me. |
@ezr-ondrej - I'm seeing the audits page fail to load when I have an audit that is missing UserInfo, with the following error in the console:
When I comment out the required props in the UserDetails component, the page loads just fine. |
So, what's the status here? Should we revert until we have the fix ready? Did someone open a tracking issue already? I suppose that should be 1.22 blocker. |
https://projects.theforeman.org/issues/26286 is for the issue I've uncovered, I'm not sure this change is related to it. Perhaps the latest audits changed while trying to bysect leading to this commit? |
Yeah, I don't see how it could be related. The delay I added doesn't delay the loading of the javascript or anything like that and with the JS error @tbrisker mentions above I think it really seems unrelated. |
Ensure menu items don't close too quickly by increasing the delay.
https://projects.theforeman.org/issues/25833