-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #26235 - Check for path in webpacked plugins #6539
Conversation
This comment has been minimized.
This comment has been minimized.
Issues: #26235 |
I moved the issue to appropriate project in Redmine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe why the path could be empty? Is this when something doesn't come from a gem?
Is this test relevant?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures unrelated, thanks @xprazak2 !
@ekohl, we register a fake plugin in test_helper to skip tests |
This caused a regression, audits page no longer loads |
The mentioned regression is introduced in #6538 already, just not reproducible on full page load. |
No, sorry bad work with redmine on my side. It is this one: #6405. |
sorry, bisect in this case didn't work well, since it seems to happen only with specific timeout |
No description provided.