Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26235 - Check for path in webpacked plugins #6539

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fixes #26235 - Check for path in webpacked plugins #6539

merged 1 commit into from
Mar 6, 2019

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Mar 5, 2019

No description provided.

@theforeman-bot

This comment has been minimized.

Sign in to view
@theforeman-bot
Copy link
Member

Issues: #26235

@xprazak2
Copy link
Contributor Author

xprazak2 commented Mar 5, 2019

Fixes failures in test env:
https://ci.theforeman.org/job/foreman_ansible-pull-request/302/database=postgresql,label=fast,ruby=2.5/testReport/junit/(root)/HostIntegrationTest__clone%20page/test_0001_clones_lookup_values/

@xprazak2
Copy link
Contributor Author

xprazak2 commented Mar 5, 2019

I moved the issue to appropriate project in Redmine.

ekohl
ekohl approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe why the path could be empty? Is this when something doesn't come from a gem?

@ekohl
Copy link
Member

ekohl commented Mar 5, 2019

Is this test relevant?

Capybara::ElementNotFound: Unable to find visible css "#environment_id"
    test/integration/host_js_test.rb:377:in `block (2 levels) in <class:HostJSTest>'

tbrisker
tbrisker approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures unrelated, thanks @xprazak2 !

@tbrisker tbrisker merged commit b65a9ef into theforeman:develop Mar 6, 2019
@xprazak2
Copy link
Contributor Author

xprazak2 commented Mar 7, 2019

@ekohl, we register a fake plugin in test_helper to skip tests

@ares
Copy link
Member

ares commented Mar 8, 2019

This caused a regression, audits page no longer loads

@ezr-ondrej
Copy link
Member

The mentioned regression is introduced in #6538 already, just not reproducible on full page load.

@ezr-ondrej
Copy link
Member

No, sorry bad work with redmine on my side. It is this one: #6405.

@ares
Copy link
Member

ares commented Mar 8, 2019

sorry, bisect in this case didn't work well, since it seems to happen only with specific timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
6 participants
@xprazak2 @theforeman-bot @ekohl @ares @ezr-ondrej @tbrisker