Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26781 - DateTimePicker placement #6750

Merged
merged 1 commit into from
May 14, 2019
Merged

Fixes #26781 - DateTimePicker placement #6750

merged 1 commit into from
May 14, 2019

Conversation

ezr-ondrej
Copy link
Member

@ezr-ondrej ezr-ondrej commented May 10, 2019 •
edited
Loading

Before 1920 resolution:
TimePicker-positioning
Before 1920/2 resolution:
DateTimePicker-owerflow-halfscreen
After 1920 resolution:
DateTimePicker
After 1920/2 resolution
DateTimePicker-halfscreen

@theforeman-bot
Copy link
Member

Issues: #26781

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.657% when pulling 7072846 on ezr-ondrej:date_picker_placement into 764439a on theforeman:develop.

@ares
Copy link
Member

ares commented May 13, 2019

Nice, @MariaAga or @amirfefer any comments related to code?

Ron-Lavi
Ron-Lavi approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@Ron-Lavi Ron-Lavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezr-ondrej, looks good !
@MariaAga I think that the main issue here is
that the DateTimePicker is sometimes out of the page,
maybe this should be automatically adjusted in a future PR?

@ezr-ondrej
Copy link
Member Author

ezr-ondrej commented May 13, 2019 •
edited
Loading

@MariaAga I think that the main issue here is
that the DateTimePicker is sometimes out of the page,
maybe this should be automatically adjusted in a future PR?

I believe the support for that is not in bootstrap-react < 1 component Overlay, which we are using in PF 3, so it would be a lot of work. I do not know if there is some plan to upgrade PF to bootstrap-react ^1.0, but if so, it would solve the problem as there the Overlay has placement auto 🙂

ares
ares approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezr-ondrej, @LaViro and @MariaAga, merging!

@ares ares merged commit 8ee8b40 into theforeman:develop May 14, 2019
@ezr-ondrej ezr-ondrej deleted the date_picker_placement branch May 14, 2019 12:25
ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 14, 2019
@ezr-ondrej
Fixes #26781 - DateTimePicker placement (theforeman#6750)
8b69327
ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 14, 2019
@ezr-ondrej
Fixes #26781 - DateTimePicker placement (theforeman#6750)
1a2153a
This was referenced May 14, 2019
Merged
Merged
ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 21, 2019
@ezr-ondrej
Fixes #26781 - DateTimePicker placement (theforeman#6750)
662c1e5
tbrisker pushed a commit that referenced this pull request May 22, 2019
@ezr-ondrej @tbrisker
Fixes #26781 - DateTimePicker placement (#6750)
cfa4f61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ares ares ares approved these changes

@Ron-Lavi Ron-Lavi Ron-Lavi approved these changes

@MariaAga MariaAga MariaAga approved these changes

Assignees
No one assigned
Labels
Needs testing UI
Projects
None yet
Milestone
No milestone
6 participants
@ezr-ondrej @theforeman-bot @coveralls @ares @Ron-Lavi @MariaAga