Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #26781 - css independent on the placement #6756

Merged
merged 1 commit into from
May 15, 2019

Conversation

ezr-ondrej
Copy link
Member

I have forgotten to check the css in #6750 and it gives different UI in other than top placement.

@ezr-ondrej
Copy link
Member Author

This is the issue:

Top:
placement_css_top
Bottom:
placement_css_bottom

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.657% when pulling 6c544a8 on ezr-ondrej:date_picker_placement into 8ee8b40 on theforeman:develop.

@theforeman-bot
Copy link
Member

Issues: #26781

Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the problem. Will merge when I see jenkins green, unless someone beats me to it.

Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezr-ondrej

@ezr-ondrej
Copy link
Member Author

@ares I believe we won't get any greener :( but katello fails are not related.

@ares
Copy link
Member

ares commented May 14, 2019

Pull requests that have a failing status can’t be merged on a phone.

So it will have to wait till tomorrow :-)

@ezr-ondrej
Copy link
Member Author

No worries 👍

@ares
Copy link
Member

ares commented May 15, 2019

Thanks @ezr-ondrej, merging!

@ares ares merged commit f3e9b8f into theforeman:develop May 15, 2019
ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants