Fixes #26781 - DateTimePicker placement (#6750) #6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26781 |
MariaAga
reviewed
May 15, 2019
| @@ -1,4 +1,4 @@ | |||
| .bootstrap-datetimepicker-widget.dropdown-menu.top { | |||
| .bootstrap-datetimepicker-widget.dropdown-menu { | |||
There was a problem hiding this comment.
Please change this into:
.bootstrap-datetimepicker-widget.dropdown-menu.top {
margin-top: -10px;
}
.bootstrap-datetimepicker-widget.dropdown-menu.bottom {
margin-top: 10px !important;
}
.bootstrap-datetimepicker-widget.dropdown-menu {
max-width: none;
otherwise the popover arrow is inside the input instead of being under it
There was a problem hiding this comment.
Please see #6761, this is PR for stable branch, we need to do it first to develop.
theforeman-bot
added
the
Stable branch
|
#6756 was merged, is this still wip? or is it ready to go to the stable branch? |
ezr-ondrej
force-pushed
the
date_picke_placement_cp122
branch
from
6450925
to
a234a80
Compare
ezr-ondrej
changed the title
|
#6761 merged as well, this is ready now. |
|
one of the js snapshot test failures is related, could you please fix that? (Report Template AutoComplete › rendering › renders report template with date input) |
|
Yeah, it was related, my bad I've missed that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for #6750 blocked by #6756. We need to cherry-pick both or neither.
I mark it WIP till it is in.