Fixes #28409 - Redux update changed snapshot #7229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we merged the redux update and the middleware together we havn't notcie those errors.
|
Issues: #28409 |
sharvit
approved these changes
Dec 4, 2019
|
The tests of this PR were red. Also, travis tests on develop are broken now. |
Tests were broken before because of 2 issues:
|
|
For Ruby gems, we would pin that package temporarily to fix the tests. |
|
It is more complicated because react-bootstrap is a dependency of patternfly-react @LaViro is investigating atm |
|
@mmoll @sharvit, I opened issues to patternfly-react and react-bootstrap. |
|
Can we pin pf in the vendor until then? Would it solve it? |
|
@sharvit this should be resolved in pf by patternfly/patternfly-react#3409 |
|
Thanks @mturley 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we merged the redux update and the middleware together we havn't notcie those errors.
Tested with the Interval Middleware and it still works as expected !