Fixes #10577 - Handle login csrf token expiry nicely #7832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #10577 |
tbrisker
commented
Jul 20, 2020
Comment on lines
-397
to
-402
| # Called from ActionController::RequestForgeryProtection, overrides | ||
| # nullify session which is the default behavior for unverified requests in Rails 3. | ||
| # On Rails 4 we can get rid of this and use the strategy ':exception'. | ||
| def handle_unverified_request | ||
| raise ::Foreman::Exception.new(N_("Invalid authenticity token")) | ||
| end |
There was a problem hiding this comment.
About time we got rid of this now that we are on rails 6 :)
| @@ -473,15 +473,15 @@ def user_set?(field) | |||
|
|
|||
| def notifications | |||
| content_tag :div, id: 'toast-notifications-container', | |||
| 'data-notifications': toast_notifiations_data.to_json.html_safe do | |||
| 'data-notifications': toast_notifications_data.to_json.html_safe do | |||
There was a problem hiding this comment.
This and the rest below are just typo fixed i noticed while working on this pr.
ShimShtein
previously approved these changes
Jul 20, 2020
ShimShtein
approved these changes
Jul 20, 2020
|
Merged, thanks, @tbrisker! |
pcreech
pushed a commit
to pcreech/foreman
that referenced
this pull request
Sep 1, 2020
Fixes #10577 - Handle login csrf token expiry nicely (theforeman#7832) (cherry picked from commit e0d14b3)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test-