updating my fork (#1)

[anandkumaragrawal]

• Fixes #29327 - Add actions to mail notification API

• Fixes #29740 - Align puppet class names

• Fixes #29741 - Login background override

• Fixes #29734 - Fix bar chart on config report page

• Bump version to 2.2-develop

• Refs #29738 - Fix string extraction for plugins

• Fixes #28850 - Make users disableable

• Fixes #29744 - Consistent session expiration for oidc ext. users

Currently the session expiration time is taken from the access token.
Since we use the idle session time out setting for all auth sources,
it would be nice to have this consistent.

• Refs #29744 - refactor the set_current_user method

• Fixes #28874 - set/get eager zero flag

• Refs #28874 - bump fog version

• Fixes #28182 - fixing broken search bar in facts

• templates - sync from community-templates

• Fixes #29733 - deprecate foreman_url without arguments

• Fixes #27879 - token is properly generated for iPXE Embedded

• Fixes #29402 - Add missing gov region for EC2

• Fixes #29796 - trends extraction warning

• Refs #29796 - statistics extraction warning

• Fixes #29761 - correct config status chart layout

host-configuration-chart class was used for both the widget and the
chart iteslf, causing the title to be displayed with incorrect margins.
Since widget classes are saved to the database, a migration was added to
update the class name in the db as well. Some styling cleanup was done
as well.

• Fixes #29881 - Require only used rss modules

• Fixes #29888 - Add ';vdsmdummy;' and 'br-int' to interface exclusion lists

• Fixes #29869 - react pages in plugins

• Fixes #29891 - add kernel release fact for rhsm

• Fixes #15628 - Require rdoc for apipie-rails

apipie-rails has rdoc optional, however, its default markup generator is
RDoc. rdoc seems to be found on most of the default OS installations
through inclusion from rubygems.

This fixes (development) setup when rdoc is missing:

`require': cannot load such file -- rdoc (LoadError)

Technically, the apipie-rails should not fail with default configuraton
when an optional dependency is not installed:
Apipie/apipie-rails#544

• Fixes #29870 - replace awesome_print with amazing_print

• Fixes #29872 - Only load used Rails frameworks

• Refs #29135 - fix section paramter in links

Now the parameter can accept any input including dots

• Fixes #28639,#28640 - fix AWS deprecation and unrecognized args warnings

• Refs #29872 - Always require test_unit railtie

It is required for defining the 'test' rake tasks.

• Fixes #29902 - Fixed bad name in NumericInput component

• refs #15628 - remove unused rdoc gem reference

• Refs #28028 - update chromedriver to match jenkins version

• templates - delete old templates on sync

• templates - sync from community-templates

• Fixes #29857 - Add DSL docs for taxonomies

• Fixes #29490 - adds http_proxy support in GCE

• Fixes #28028 - Drop chromedriver dependency

This prefers the NPM path it used to look at, but falls back to looking
in $PATH.

• Fixes #29714 - Drop puppetclass_id column from Lookup_keys

• Fixes #29709 - Check properly managed interfaces

• Fixes #29578 - add sorting feature to reports

Reports usually generate a tabular data using the report_render
macro. There is no way to sort such output. This patch adds a new
parameter to report_render macro allowing to specify one or more
columns for sorting.

<%= report_render order: 'Name' -%>
<%= report_render order: [ 'Name', 'Age' ] -%>

Also it may be useful to reverse the order of the report. For this
purpose a second parameter was added

<%= report_render order: [ 'Name' ], :reverse_order: true -%>

Note that both can be used independently.

For unknown column, rendering error is presented calling out the values
that were not recognized. We support all headers registered using the
report_headers macro as well as names used when calling report_row
macro, as illustrated in the following example

<%- report_headers 'Name' -%>
<%- report_row Name: 'Ares', Age: 123 -%>
<%= report_render order: 'Age' %>

The performance impact was checked. Ordering roughly doubles the raw
rendering time, meaning the time the report_render method takes. The
order reversing is nearly instant.

On report with 10_000 rows, it added 0.05s which in such
big reports is marginal thing. Usually the report spend minutes on
parsing ActiveRecord data.

• Fixes #29716,#29283 - Bump fog-ovirt version

• Fixes #29936 - Bump fog-aws version to 3.6.5

• fixes #26925 - support host registration

• Refs #26925 - fix host registration tab styles

• Fixes #29940 - add select to FormField

• Fixes #28920 - Add queries and mutation for settings

• Refs #28920 - Settings resolve permission name

• Refs #28920 - Add more tests

• Fixes #28116 - introduce CentOS mirror (8.x) inst. media

• Fixes #29958 - fix name convention for auth sources tab

• Fixes #29858 - Add DSL docs for domains

• Fixes #29859 - Add DSL docs for SSH keys

• Fixes #29910 - Refactor setting option selection

• Refs #29910 - Remove dynamic method definition

• Fixes #29702 - added image validation check to ovirt

• Fixes #29900 - Add Cpu/Cores react component

• Fixes #29850 - Add DSL docs for realm

• Fixes #29990 - stop clear API response on polling

Each polling response is getting reset on every new request
since initially in the APIReducer we set response to null.

• Fixes #29974 - allow subnet helpers (Fixes #29974 - allow subnet helpers #7713)

• Fixes #29909 - Add option to fetch all records from API

• Fixes #29973 - Move property docs next to the jail

• Fixes #29855 - Add DSL docs for users

• Fixes #29856 - Add DSL docs for subnets

• Fixes #29903 - Add select functionality to table

• Fixes #29219 - Deploy Storybook to surge.sh (Fixes #29219 - Deploy Storybook to surge.sh #7648)

Co-authored-by: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl

• Fixes #30052 - Do not dump dynflow tables when dumping db schema

This should fix 'PG::InvalidForeignKey: ERROR: there is no unique
constraint matching given keys for referenced table "dynflow_actions"'
error appearing in plugin tests.

• Fixes #30014 - set MALLOC_ARENA_MAX=2 for puma

• Fixes #28664 - support API middleware response callbacks (Fixes #28664 - support API middleware response callbacks #7337)

• Fixes #28664 - API middleware handleError param

the handleError callback will get called on the API request error.
the consumer won't need to wait until the component
will get updated by the store, and can invoke any method they want.

• Fixes #28664 - API middleware handleSuccess param

• Fixes #29852 - Add DSL docs for PTables

• Fixes #30041 - Don't allow impersonate disabled user

• Fixes #30086 - move foremanUrl into ReactApp

plugins JS tests have access only to the ReactApp folder in Foreman,
it means that when trying to import something out of the folder,
jest can't handle it.

• Fixes #30097 - media provider friendly_name method removed

• Fixes #28515 - refactor power status

Refactor the component to use the API middleware

• Fixes #29853 - Add DSL docs for OS

• Refs #26925 - registration token method naming

• Fixes #29988 - Upgrade Rails to 6.0.3.1

• Fixes #29854 - Add DSL docs for host groups

• Fixes #29967 - encrypte root password in settings

• Fixes #30056 - Forcing Unicode in reports

• Fixes #30001 - fix auth sources breadcrumbs

• Fixes #30139 - UserDropdowns.scss is a duplicate

• Fixes #30030 - use media_type where appropriate

Also, set config.action_dispatch.return_only_media_type_on_content_type
to false, as it will be in Rails 6.1.

• Fixes #28303 - connect react router to redux

• Fixes #30138 - report template download button

• Fixes #30107 - graphql powerStatus field

• Fixes #30154 - Use LazyValidator for models

• Fixes #29498 - improve pending_migrations check

• Fixes #28226 - upgrade to sprockets 4

• Fixes #30110,#29968 - upgrade vendor to v4.8.0

• Fixes #29331 - use patternfly v4 fonts

• Fixes #29851 - Add DSL docs for NIC

• Fixes #28986 - Hide host selector from report templates

• Fixes #29849 - Add DSL docs for hosts

• Fixes #30085 - return on interval middleware stop

• Fixes #29445 - restrict STI deletion to admin (Fixes #29445 - restrict STI deletion to admin #7694)

When obsolete STI records deletion was introduced, we allowed even
non-admin users to delete that. This patch makes it possible only for
admins to delete records from the database. Non-admin users only see a
short message explaining what happened, that they should contact
administrator and request ID that can help administrator to figure out
what happened.

It was also necessary to add explicit require_login call, otherwise
User.current was nil in case the stack failed before user was loaded.
This also made the page looks much nicer, becase the menu can be
properly rendered.

• Fixes #30178 - User role with long name without spaces overlap to another column (Fixes #30178 - User role with long name overlaps to another column #7764)

• Fixes #30146 - Allow running Rake tasks as Dynflow clients

• Refs #29331 - increase the vertical nav font-size

• Refs #30127 - extract import_facts from host

• Refs #30127 - drop setting enable_orchestration_on_fact_import

• Refs #30085 - pass stop_interval action to reducer

last refactor did fix the severals warnings we got
but the action actually should not be stopped in the middleware
in order of the reducer to update the state correctly
removing that interval key from state.

• Fixes #26772 - Use react-router on hw models page

• Refs #26772 - Use toasts from context

• Fixes #30080 - run plugins react tests in action

• Fixes #30232 - userdropdown pf4

• Refs #30232 - icon in userdropdown to pf4

• Fixes #30231 - Fix keyboard to keyboard_layout in ovirt CR API

• Fixes #30152 - Unfreeze full_name for settings

• Fixes #30247 - do not delete VMs by default

We've seen multiple users deleting their VMs when they deleted host in
Foreman. That still seems to be very unexpected especially in case of
unmanaged hosts. It's safer to keep the VM and delete it only if users
explicitly want to.

This changes the default behavior and we'll need to cover that in
release notes. However it probably causes less pain than having VMs
running and consuming resources, when people forget to destroy them.

• Fixes #30229 - Fix errors when searching os that not exists

• Fixes #29862 - Add DSL docs for report

• Fixes #29864 - Add DSL docs for loaders

• Fixes #29863 - Add DSL docs for snippets

• Fixes #29865 - Add DSL docs for inputs macros

• Fixes #29866 - Add DSL docs for host template macros

• Fixes #30310 - add missing translations

• Refs #30098 - drop trends import

• Fixes #30317 - Do not add comment to locked template

• Fixes #30196 - Remove double listed marcos

• Refs #30080 - run GH react tests on relevant files

• Refs #30098 - Drop trends UI

• Fixes #30205 - smart proxies statuses with logs feature disabled

Grab failed_features in a more specific way, not relying on "logs"
feature that might be disabled.

Signed-off-by: Pavel Moravec pmoravec@redhat.com

• Fixes #27319 - add vnc console for kubevirt

• Fixes #30207 - isolate LookupKeysControllerTest

• Fixes #30144 - use media_type check not content_type

• Refs #30098 - Deprecate trends API endpoints

• Fixes #30216 - refactor the js session-storage

• Fixes #30246 - Upgrade vendor to v4.11.1

• Fixes #30356 - remove dependency and use surge directly

• Fixes #30244 - prevent Filter empty search_condition

when inherited taxonomy search is empty, it would save search_condition as empty string instead of nil, we need to nilify in such case.

• Refs #30098 - Drop trends models

• Fixes #30098 - Drop trends permissions

• Fixes #30372 - Fix creation of ovirt CR via api

• Fixes #29683 - fix params search on hg,os,domain,subnet pages

• Refs #29683 - add search by param tests for models

• templates - sync from community-templates

This is the last sync from the community templates repo

• Fixes #30143 - passing root_url without section

• Refs #30080 - gh action to match sub-directories

• Fixes #30175,#30195 - Moving Quota validation to before_save in Ovirt CR (Fixes #30175,#30195 - Moving Quota validation to before_save in Ovirt CR #7774)

Co-authored-by: Shira Maximov shiramaximov@gmail.com

• Fixes #30401 - remove fixture usage from classification tests (Fixes #30401 - remove fixture usage from classification tests #7817)

• Fixes #30351 - Adjust the wording on hosts so that it reflects the value represents the Smart Proxy whose puppet_url will be used

• Fixes #30126 - use facets fact parsing

• Fixes #28357 - BMC Subnet-Proxy association

• Fixes #29993 - Drop Puppetrun

• Fixes #30222 - Isolate LookupValue tests

• Fixes #28516 - support all API operations

• Fixes #30228 - Refactor the Layout component

refactor the layout component to use react-hooks

• Fixes #29992 - pass stopInterval in handleError

• Refs #29993 - Remove before_action puppetrun

• Fixes #10577 - Handle login csrf token expiry nicely (Fixes #10577 - Handle login csrf token expiry nicely #7832)

• Fixes #30151 - Provide a generic help for writing templates

• Refs #30151 - incorporate review feedback

• Refs #30151 - review changes

• Refs #30151 - fix routing

• Fixes #30382 - Don't translate taxonomy names

• Fixes #30412 - fix shifted react-container

• Refs #27298 - transient mailer test failure

• Refs #30080 - don't fail-fast react plugins tests

• Fixes #29860 - Add base macros docs (Fixes #29860 - Add base macros docs #7768)

• Fixes #30431 - Grub2 IPv6 only subnet nil error

• Fixes #28384 - Allow hiding stacktraces in the UI

• Fixes #30044 - Initial Host Details Page Redesign

• add audits

• add actions bar

• add tests, proptype and change skeleton loading

• fix css gray background

• Refs #30331 - Adds PF4 CustomContextSelector

• Refs #30331 - move layout proptypes to helper

• Fixes #30470 - Add DSL docs for smart proxy (Fixes #30470 - Add DSL docs for smart proxy #7846)

• Refs #29940 - Refactor select options

• Fixes #30484 - Fix assets for graphiql

• Refs #30044 - fix rpm build failure related to pf4 styles

• Fixes #29332 - update the breadcrumbs to pf4

• Fixes #30375 - fix os_minor search to not show empty minor

• Fixes #30185 - Change console files to be compatible to python3

• Fixes #30441 - Global Registration Template API endpoint (Fixes #30441 - Global Registration Template API endpoint #7839)

• Fixes #30508 - Upgrade vendor to v4.12.0

• Fixes #30408 - full report data for scanning

• Fixes #30495 - Add main_app prefix to some route helpers

• i18n - extracting new, pulling from tx

• Fixes #30339 - isolate LookupKey tests

• Fixes #30319 - Taxonomy scope for AuthSources#index

• Fixes #30526 - provisioning templates will be taken from CR in HG too

• fixes #30499 - update latest versions of fedora, ruby and node

also fixed an issue where spring was unable to load and removed
it from the container.

• Fixes #30437 - add react context to pagination broken story

• Refs #30159 - drop Statistics UI

• Fixes #30159 - drop Statistics backend

• Fixes #30551 - Move section to a parameter in documentation links

• Refs #28384 - handle case when request ID is missing

• Fixes #30127 - always skip orchestration

bb84e41 removed the setting on bases of what we've skipped orchestration.
Without the setting, the method no longer has any use.
There are no current subclasses that could override it so the method can be dropped.

• Fixes #30587 - forgeries rake task

We can't include FactoryBot methods, because it breaks host_related factories.

• Fixes #30563 - link to generated page instead of directory

• Remove quotation marks in conditional example, so it can be copy-pasted

• Fixes #30528 - Run rake console as dynflow client (Fixes #30528 - Run rake console as dynflow client #7871)

• Fixes #30528 - Run rake console as dynflow client

Dynflow identifies separate runtime units (think processes) as worlds. Dynflow
distinguishes two kinds of worlds, executors worlds which can actually perform
things and client worlds, which can only ask the executor worlds to execute
something on their behalf.

Due to the recent move to sidekiq and puma, Dynflow gets initialized slightly
differently and all rake tasks now don't register themselves as Dynflow worlds.
This is mostly fine, since the world registration isn't exactly free operation
and most of the rake tasks don't interact with Dynflow in any way. However,
tasks which need to interact with Dynflow started failing. To fix this, we
introduced the dynflow:client rake task in 4e53859, on which other tasks can
depend and which registers the current process as a Dynflow client.

This patch allows running rails console as a Dynflow client so users can
interact with Dynflow from the console.

• Fixes #30617 - Fix Change Owner bulk action

fabec12 removed SETTINGS[:login] but
377ff66 still used it. This is probably
a rebase that missed the change.

• Fixes #30554 - Update Storybook docs for plugins and mount_react_component

• Fixes #30510 - Compare host packages report

• Bump version to 2.3-develop

• Fixes #30614 - webcomponent mount on ptable welcome

Transfer to a new mounter point introduced in 6f0d802

• Fixes #30620 - Fix CR creation from the API

• Fixes #30611 - webcomponent mount FactChart

Transfer to a new mounter introduced in 6f0d802

• Add single commit check to GH actions

• Fixes #30430 - fix split_matcher

• Fixes #30597 - replace mount_react_component in pagination

• Fixes #30613 - Use new mounter for report diff

• Fixes #30610 - Use new react mounter for vmware vm

• Fixes #30650 - fixed linter error in HOC.js

• Fixes #30558 - Fix typos in templates DSL (Fixes #30558 - Fix typos in templates DSL #7878)

• Fixes #30600 - use react_component in asciidoc

replace the mount_react_component with react_component
in the developer_docs

• Refs #30659 - pin friendly_id to < 5.4

The new release causes a breaking change to friendly.find methods.
Pinning for now until a new version is released fixing this change.

• Fixes #30618 - remove foreman-js:link (Fixes #30618 - remove foreman-js:link #7888)

please use the link command provided by foreman-js instead
see: https://github.com/theforeman/foreman-js

Co-authored-by: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl

• Fixes #30512 - avoid query for smart proxy settings (Fixes #30512 - avoid query for smart proxy settings #7864)

While this is less efficient, the number of
smart proxy features is low. This allows settings
to be read on an unsaved objects, improving testing
and allowing us to rely on settings in before_create.

• Fixes #30667 - Reuse log level configured for Dynflow for Sidekiq

Sidekiq uses info log level by default, which is rather chatty but at the same
time doesn't really provide anything useful. This change makes Sidekiq "inherit"
the log level configured for Dynflow.

• Fixes #30595,#30656 - support rendering multiple distribution widgets

migrate the distribution_widget to use react_component.

• Fixes #30634 - Windows Deploy Templates Domain Join

• Fixes #30328 - Adds patternfly 4 Loading react component

This is a component to show a loading spinner, with or without text. We currently have this in Katello and this would make it available in Foreman.

• Fixes #30643 - Allow inheriting auth source classes (Fixes #30643 - Properly handle AuthSource subclasses #7905)

AuthSource subclasses may be inherited, leading scopes to return
unexpected results - for example, AuthSource.except_hidden returned auth
sources that inherited the AuthSourceHidden class. The scopes have been
modified to also take into account the descendants of the various types.

• Fixes #30598 - replace mount_react_component with react_component

replace mount_react_component with react_component in
app/views/report_templates/report_data.html.erb

• Fixes #30599 - replace mount_react_component in login

• Fixes #30605 - replace mount_react_component in search

• Fixes #30556 - Get an accurate err for invalid hosts in report (Fixes #30556 - Get an accurate err for invalid hosts in report #7897)

• Fixes #30415 - use only repos managed by sub-man (Fixes #30415 - use only repos managed by sub-man #7823)

• Fixes #30442 - Global registration template params & host registration (Fixes #30442 - Global registration template params & host registration #7859)

• Fixes #30555 - Authorizer uses subselect for joined_on (Fixes #30555 - Authorizer uses subselect for joined_on #7877)

if we use joined_on class, we are using the where clause on that class through the association.
This is very volatile and it doesnt play well with the Host STI.

See the test for example failure

• Fixes #30466 - trigger toasts from API middleware

• Fixes #30538 - Update set of available events

• Fixes #30709 - disable hound eslint checks

• Fixes #30712 - pin shoulda_matcher < 4.4

• Fixes #30348 - trends cleanup task

• Fixes #30606 - replace mount_react_component in extlogout

• Refs #30348 - statistic permission cleanup

• Fixes #30609 - Use new react mounter for users form

• Fixes #29984 - Validate all ovirt volume attrs are string

• Fixes #30684 - add password edit button to the http proxy form

It should allow users to send the form without editing the password

• Fixes #30596 - replace mount_react_component in config reports

• Fixes #30492 - Fixed bug in Highly Available checkbox in ovirt cp

• Fixes #30615 - Fix incorrect ipv6 error showing in host interfaces

• Fixes #29356: Use puma-plugin-systemd to provide systemd notify support

This points to a fork of puma-plugin-systemd maintained by theforeman
organization to ensure this works with Puma 4.

• Fixes #30730 - Implement systemd notify support for dynflow-sidekiq

• Fixes #30627 - mac address is not required for virtual resources

• Fixes #30638 - replace react-numeric-input with rc-number-input

• Fixes #30601 - replace mount_react_component in toasts

• Fixes #30706 - Gracefully recover from CR connection error

If the connection fails to the compute resource due to networking
issues we should capture it nicely rather than causing a 500 page.

• Fixes #30603 - replace mount_react_component in templates helper

• Refs #27298 - drop unstable audit mailer test

This test has been failing randomly very often and three previous
attempts at fixing it have all failed.

• Fixes #30739 - User must login with the assigned auth source

• Fixes #30778 - Report Template host_cores macro

• Fixes #30744 - fix host creation when volume is empty

• Fixes #30786 - Fix yup snapshots

• Fixes #30763 - move architecture to abstract provider

• Fixes #30608 - Use new react mounter for templates form

• Fixes #30790 - wrap all examples in apipie_dsl_example() (Fixes #30790 - wrap all examples in apipie_dsl_example() #7966)

• Fixes #30698 - set title for new/edit auth source ldaps

• Fixes #30768 - remove API status selector default

Co-authored-by: yifatmakias ymakias@redhat.com
Co-authored-by: Ondrej Prazak oprazak@redhat.com
Co-authored-by: Ron Lavi 1ronlavi@gmail.com
Co-authored-by: Tomer Brisker tbrisker@gmail.com
Co-authored-by: Jonathon Turel jturel@gmail.com
Co-authored-by: Dominik Matoulek domitea@gmail.com
Co-authored-by: Rahul Bajaj rahulrb0509@gmail.com
Co-authored-by: Bernhard Suttner suttner@atix.de
Co-authored-by: Ondřej Ezr oezr@redhat.com
Co-authored-by: Amir Fefer amirfefer@gmail.com
Co-authored-by: Lukas Zapletal lzap+git@redhat.com
Co-authored-by: Aditi Puntambekar apuntamb@redhat.com
Co-authored-by: Leos Stejskal lstejska@redhat.com
Co-authored-by: Ranjan Kumar ranjankumar188@gmail.com
Co-authored-by: Viliam Krizan vkrizan@redhat.com
Co-authored-by: Michael Moll kvedulv@kvedulv.de
Co-authored-by: Shimon Shtein sshtein@redhat.com
Co-authored-by: Ohad Levy ohadlevy@gmail.com
Co-authored-by: Oleh Fedorenko ofedoren@redhat.com
Co-authored-by: kgaikwad kavitagaikwad103@gmail.com
Co-authored-by: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl
Co-authored-by: Shira Maximov shiramaximov@gmail.com
Co-authored-by: Marek Hulan mhulan@redhat.com
Co-authored-by: Timo Goebel mail@timogoebel.name
Co-authored-by: Ondřej Pražák xprazak2@users.noreply.github.com
Co-authored-by: MariaAga mariaagaphonchev@gmail.com
Co-authored-by: Jeremy Lenz jlenz@redhat.com
Co-authored-by: Adam Ruzicka aruzicka@redhat.com
Co-authored-by: Suraj Patil patilsuraj767@gmail.com
Co-authored-by: Avi Sharvit sharvita@gmail.com
Co-authored-by: Marek Hulán ares@users.noreply.github.com
Co-authored-by: Pavel Moravec pmoravec@redhat.com
Co-authored-by: Yifat Makias 42476762+yifatmakias@users.noreply.github.com
Co-authored-by: Karl Vollmer karl.vollmer@gmail.com
Co-authored-by: Tomer Brisker tbrisker@users.noreply.github.com
Co-authored-by: Amit Upadhye amitupadhye@foreman.example.com
Co-authored-by: Mirek Długosz mzalewsk@redhat.com
Co-authored-by: Adam Růžička adamruzicka@users.noreply.github.com
Co-authored-by: Justin Sherrill jlsherrill@gmail.com
Co-authored-by: Matthias Hähnel github.com@drhaehnel.de
Co-authored-by: John Mitsch jomitsch@redhat.com
Co-authored-by: Bernhard Suttner sbernhard@users.noreply.github.com
Co-authored-by: Justin Sherrill jsherril@redhat.com
Co-authored-by: Eric D. Helms ericdhelms@gmail.com

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Can one of the admins verify this patch?

[houndci-bot]

Expected selector "#parameters .table tr.fields td" to come before selector "#interfaceList.table tr.has-error td:first-child" no-descending-specificity
Expected selector "#parameters .table tr.fields td" to come before selector "#interfaceList.table tr.has-error td:last-child" no-descending-specificity

[houndci-bot]

Expected selector "#parameters .table tr.error-msg-block td" to come before selector "#interfaceList.table tr.has-error td:first-child" no-descending-specificity
Expected selector "#parameters .table tr.error-msg-block td" to come before selector "#interfaceList.table tr.has-error td:last-child" no-descending-specificity

[houndci-bot]

Expected selector "#parameters .table tr td" to come before selector "#interfaceList.table tr td:first-child" no-descending-specificity
Expected selector "#parameters .table tr td" to come before selector "#interfaceList.table tr.has-error td" no-descending-specificity
Expected selector "#parameters .table tr td" to come before selector "#interfaceList.table tr.has-error td:first-child" no-descending-specificity
Expected selector "#parameters .table tr td" to come before selector "#interfaceList.table tr.has-error td:last-child" no-descending-specificity

[houndci-bot]

Unexpected missing generic font family font-family-no-missing-generic-family-keyword

[houndci-bot]

Expected selector ".white-header th" to come before selector "#interfaceList.table tr th" no-descending-specificity
Expected selector ".white-header th" to come before selector "#interfaceList.table tr th:first-child" no-descending-specificity

[houndci-bot]

Expected selector ".config_group_group li" to come before selector "#settings li" no-descending-specificity
Expected selector ".puppetclass_group li" to come before selector "#settings li" no-descending-specificity

[houndci-bot]

Expected selector "#interfaceList.table tr.has-error td" to come before selector "#interfaceList.table tr.has-error td:first-child" no-descending-specificity
Expected selector "#interfaceList.table tr.has-error td" to come before selector "#interfaceList.table tr.has-error td:last-child" no-descending-specificity

[houndci-bot]

Expected selector "#interfaceList.table tr td" to come before selector "#interfaceList.table tr td:first-child" no-descending-specificity

[houndci-bot]

Expected selector "#interfaceList.table tr th" to come before selector "#interfaceList.table tr th:first-child" no-descending-specificity

[houndci-bot]

Expected selector ".modal-body" to come before selector "#confirmation-modal .modal-body" no-descending-specificity

[theforeman-bot]

Issues: #29327 #29740 #29741 #29734 #29738 #28850 #29744 #29744 #28874 #28874 #28182 #29733 #27879 #29402 #29796 #29796 #29761 #29881 #29888 #29869 #29891 #15628 #29870 #29872 #29135 #28639 #28640 #29872 #29902 #15628 #28028 #29857 #29490 #28028 #29714 #29709 #29578 #29716 #29283 #29936 #26925 #26925 #29940 #28920 #28920 #28920 #28116 #29958 #29858 #29859 #29910 #29910 #29702 #29900 #29850 #29990 #29974 #29909 #29973 #29855 #29856 #29903 #29219 #30052 #30014 #28664 #28664 #28664 #29852 #30041 #30086 #30097 #28515 #29853 #26925 #29988 #29854 #29967 #30056 #30001 #30139 #30030 #28303 #30138 #30107 #30154 #29498 #28226 #30110 #29968 #29331 #29851 #28986 #29849 #30085 #29445 #30178 #30146 #29331 #30127 #30127 #30085 #26772 #26772 #30080 #30232 #30232 #30231 #30152 #30247 #30229 #29862 #29864 #29863 #29865 #29866 #30310 #30098 #30317 #30196 #30080 #30098 #30205 #27319 #30207 #30144 #30098 #30216 #30246 #30356 #30244 #30098 #30098 #30372 #29683 #29683 #30143 #30080 #30175 #30195 #30401 #30351 #30126 #28357 #29993 #30222 #28516 #30228 #29992 #29993 #10577 #30151 #30151 #30151 #30151 #30382 #30412 #27298 #30080 #29860 #30431 #28384 #30044 #30331 #30331 #30470 #29940 #30484 #30044 #29332 #30375 #30185 #30441 #30508 #30408 #30495 #30339 #30319 #30526 #30499 #30437 #30159 #30159 #30551 #28384 #30127 #30587 #30563 #30528 #30528 #30617 #30554 #30510 #30614 #30620 #30611 #30430 #30597 #30613 #30610 #30650 #30558 #30600 #30659 #30618 #30512 #30667 #30595 #30656 #30634 #30328 #30643 #30598 #30599 #30605 #30556 #30415 #30442 #30555 #30466 #30538 #30709 #30712 #30348 #30606 #30348 #30609 #29984 #30684 #30596 #30492 #30615 #29356 #30730 #30627 #30638 #30601 #30706 #30603 #27298 #30739 #30778 #30744 #30786 #30763 #30608 #30790 #30698 #30768

[lzap]

Uh this caused our bot to associate all the tickets mentioned above with this PR. Please do be careful before pushing and check your commits, thanks!

[anandkumaragrawal]

@lzap , Extremely sorry for this. I will be extra careful here onwardxs.