Drop environments migrations #8550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31062 |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
Legacy JS
ezr-ondrej
force-pushed
the
drop_environments_migrations
branch
from
075b439
to
6d5a4ec
Compare
ezr-ondrej
force-pushed
the
drop_environments_migrations
branch
from
6d5a4ec
to
67b47c2
Compare
ezr-ondrej
force-pushed
the
drop_environments_migrations
branch
from
67b47c2
to
9dd5515
Compare
Details of extraction: - theforeman/foreman_puppet#26 - theforeman/foreman_puppet#24 - theforeman/foreman_puppet#38 (integration test)
States the API deprecated and directs users to using a plugin. Details of extraction theforeman/foreman_puppet#30
Drops OverrideValues API tangled with Puppet, but leaves common partials, these can be used by all the plugins. Details of extraction in theforeman/foreman_puppet#32
Drops Concern used just for puppet, that was having a missleading naming. Extracted to plugin in theforeman/foreman_puppet#29.
Extract puppet extenstions to LookupValue. Extracted in theforeman/foreman_puppet#10
Drops UI controller and routes for Environment. Extracted in: - theforeman/foreman_puppet#46 - theforeman/foreman_puppet#52
Drop templates, helpers and host action from multiple_actions menu. Extracted in theforeman/foreman_puppet#45
Drop Change Environment action and all its pieces. Extracted in theforeman/foreman_puppet#57.
Drops config_groups node from Host and Hostgroup API responses. Extracted in theforeman/foreman_puppet#66
Drops the environment field and all js attached to it. Extracted in theforeman/foreman_puppet#64.
Drops ConfigGroup controller, tests and parameter filter. Extracted in theforeman/foreman_puppet#16
Drops notion of Environments from Host API. Extracted in theforeman/foreman_puppet#50
Drops Puppetclass models and their usage. Extracted in theforeman/foreman_puppet#81 Tests extracted in: - hostgroup - theforeman/foreman_puppet#85
Added to the plugin in theforeman/foreman_puppet#12
Added to the plugin in theforeman/foreman_puppet#133
Removes uses of environment from Host
Remove uses of environment from Hostgroup.
Removes uses of Environment from Nic::Managed model
Removes uses of Environment from Report model.
Removes taxation of Environment.
Removes uses of Environment from User. Extraction of `#visible_environments`: theforeman/foreman_puppet#126
Removes uses of Environment in PuppetFactParser and implement plugin guard to import plugin Envrionment if plugin is installed.
Removes Environment related notes from tests, mostly just Host being uselessly provided an environment.
We need to introduce a guard for Environment being present in settings, as we are about to drop Environment. Reimplementation and movement of the Puppet settings is separate commit.
These migrations had been added to the plugin foreman_puppet_enc. Details of addition theforeman/foreman_puppet#13
This is completely dropped, in plugin we use factories instead.
Drops all migrations related to environments. Removes all the relations to the environments. Adds a migration to drop environments from Hostgroup and Host. Extracted in theforeman/foreman_puppet#41.
ezr-ondrej
force-pushed
the
drop_environments_migrations
branch
from
9dd5515
to
f8f7195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test of drop environments on Jenkins.