Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20170 - Fix the UI for delete modal #358

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

rabajaj0509
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

@rahulbajaj0509, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

Issues: #20169

@rabajaj0509 rabajaj0509 changed the title Fixes #20169 - Fix the UI for delete modal Fixes #20170 - Fix the UI for delete modal Jun 30, 2017
Copy link
Member

@ohadlevy ohadlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you please provide a before/after screenshot?

@dLobatog
Copy link
Member

[test]

@rabajaj0509
Copy link
Member Author

Before :
delete_modal

After:
deletemodalfix

@rabajaj0509
Copy link
Member Author

i guess, this looks good but as the number of entries will increase the 'organization' might collide with the submit button. Can someone give a feedback on this ?

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulbajaj0509 If try to delete many, the modal will become larger but it will not collide with the Submit button. You can reproduce the situation already in the Hosts page, trying to remove many hosts at the same time.

@dLobatog dLobatog merged commit 06cb5f1 into theforeman:develop Jun 30, 2017
@dLobatog
Copy link
Member

Thanks @rahulbajaj0509 !

@ohadlevy
Copy link
Member

ohadlevy commented Jul 2, 2017

/cc @Rohoover

@Rohoover
Copy link

Rohoover commented Jul 7, 2017

Can we use the Inline messaging warning instead of the current style? The current style doesn't really exist anywhere else with any consistency.

http://www.patternfly.org/pattern-library/communication/inline-notifications/

@rabajaj0509
Copy link
Member Author

@Rohoover thanks for the input, would surely make the changes and raise a pr :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants