-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20170 - Fix the UI for delete modal #358
Conversation
@rahulbajaj0509, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
Issues: #20169 |
45e69c2
to
d4805b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you please provide a before/after screenshot?
[test] |
i guess, this looks good but as the number of entries will increase the 'organization' might collide with the submit button. Can someone give a feedback on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulbajaj0509 If try to delete many, the modal will become larger but it will not collide with the Submit button. You can reproduce the situation already in the Hosts page, trying to remove many hosts at the same time.
Thanks @rahulbajaj0509 ! |
/cc @Rohoover |
Can we use the Inline messaging warning instead of the current style? The current style doesn't really exist anywhere else with any consistency. http://www.patternfly.org/pattern-library/communication/inline-notifications/ |
@Rohoover thanks for the input, would surely make the changes and raise a pr :) |
No description provided.