Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28299 - enable rubocop-rails properly #491

Closed
wants to merge 1 commit into from

Conversation

lzap
Copy link
Member

@lzap lzap commented Nov 19, 2019

I've noticed that there is a warning message, this is the way how Rubocop Rails should be included.

@theforeman-bot
Copy link
Member

Issues: #28299

@lzap
Copy link
Member Author

lzap commented Dec 3, 2019

Test failure irrelevant, @timogoebel I actually implemented what we've talked about yesterday :-)

@lzap
Copy link
Member Author

lzap commented Dec 3, 2019

This weird error I don't see locally:

SystemStackError: stack level too deep
    test/unit/foreman/http_proxy_test.rb:120:in `block (2 levels) in <class:HTTPProxyTest>'
    test/test_helper.rb:68:in `before_setup' (SystemStackError)
/usr/local/rvm/gems/ruby-2.5.1@foreman_discovery-pull-request-2/gems/excon-0.70.0/lib/excon/connection.rb:369    

Any idea? What's this.

@timogoebel
Copy link
Member

Might be two gems that extend excon. One might use alias_method_chain and the other one Module.prepend. Just a thought, haven't verified this.

@lzap
Copy link
Member Author

lzap commented Mar 6, 2020

Let's rebase and cross fingers.

@ezr-ondrej
Copy link
Member

see #498 we're on 0.80 now and it seems we are not testing any of the .rb files

@lzap
Copy link
Member Author

lzap commented Apr 17, 2020

Closing in fav of #498

@lzap lzap closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants