Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smart proxies #146

Closed
wants to merge 3 commits into from
Closed

Conversation

ezr-ondrej
Copy link
Member

No description provided.

@ezr-ondrej
Copy link
Member Author

Or should we add the proxies on Host?

ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 17, 2021
Extract PuppetProxy and PuppetCAProxy.

Extracted in: theforeman/foreman_puppet#146
@timogoebel
Copy link
Member

timogoebel commented May 18, 2021

Or should we add the proxies on Host?

I'm not sure if I'm familiar enough with the code, but can we delegate the methods from Host model to the facet object? Just for compatibility.

@ezr-ondrej
Copy link
Member Author

I'm not sure if I'm familiar enough with the code, but can we delegate the methods from Host model to the facet object? Just for compatibility.

We definitelly can, but I'm not sure if that's the best way forward as there is specialized API for plugins to add their proxies to Host model. So I'm not sure what's the prefered way. I think that today it's not really being used, but the proxies would be great to have together I think, so something like "All host proxies" queries would be easy to do.

@timogoebel
Copy link
Member

as there is specialized API for plugins to add their proxies to Host model

Yep, I'm quite familiar with the API as I initially wrote it. :-D

I'm all for using that API to register the proxies, that makes a lot of sense imho.

ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request May 23, 2021
Extract PuppetProxy and PuppetCAProxy.

Extracted in: theforeman/foreman_puppet#146
@timogoebel
Copy link
Member

Looks like this is still part of core. Do we need this PR?

ezr-ondrej added a commit to ezr-ondrej/foreman that referenced this pull request Jul 28, 2021
Extract PuppetProxy and PuppetCAProxy.

Extracted in: theforeman/foreman_puppet#146
@ezr-ondrej
Copy link
Member Author

I believe this should get in, but only for Foreman 3.1 release.

@timogoebel
Copy link
Member

I believe this should get in, but only for Foreman 3.1 release.

@ezr-ondrej: Do you mind creating a milestone for this so we have better visibility? Thanks.

@ezr-ondrej ezr-ondrej added this to the Version 2.0 milestone Jul 29, 2021
@ezr-ondrej ezr-ondrej modified the milestones: Version 2.0, Version 1.0 Nov 11, 2021
@ezr-ondrej ezr-ondrej added the blocked This PR is blocked on something label Mar 23, 2022
@stejskalleos
Copy link
Contributor

Closing the PR since there haven't been any updates for almost two years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants