Puppet extraction #8510
Merged
Puppet extraction #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31130 |
theforeman-bot
added
Waiting on contributor
Needs testing
Not yet reviewed
Legacy JS
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
d824824
to
ca1b1e5
Compare
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
ca1b1e5
to
cdaa5cd
Compare
ekohl
requested changes
May 18, 2021
app/controllers/concerns/api/import_puppetclasses_common_controller.rb
Outdated
Show resolved
Hide resolved
| str << (comb.environment_id.nil? ? _("None") : comb.environment.to_s) | ||
| str.join(" / ") | ||
| end.to_sentence | ||
| template.template_combinations.map { |comb| comb.hostgroup.to_s }.to_sentence |
There was a problem hiding this comment.
Well logically it should not, having template combination with no association makes no sense :)
Technically I hope not xD
| @@ -1,5 +1,5 @@ | |||
| module SmartProxiesHelper | |||
| TABBED_FEATURES = ["Puppet", "Puppet CA", "Logs"] | |||
| TABBED_FEATURES = ["Puppet CA", "Logs"] | |||
There was a problem hiding this comment.
It's weird to me that Puppet is removed but Puppet CA stays. Especially if assignment of hosts to a Puppetserver will remain.
There was a problem hiding this comment.
Agreed it is weird, that's because it is not finished, both Puppet and Puppet CA should be extracted, according to my last info.
| @@ -15,8 +15,6 @@ module HostInfoExtensions | |||
| included do | |||
| # Add default providers | |||
| HostInfo.register_info_provider(HostInfoProviders::StaticInfo) | |||
| HostInfo.register_info_provider(HostInfoProviders::ConfigGroupsInfo) | |||
| HostInfo.register_info_provider(HostInfoProviders::PuppetInfo) | |||
There was a problem hiding this comment.
I really dislike that this removes the puppetmaster and puppet_ca parameters. Especially since those remain in the host model. I also think you'll drop the ip, ip6 and mac.
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
4b33e34
to
6df37ec
Compare
theforeman-bot
added
Needs re-review
Waiting on contributor
and removed
Waiting on contributor
labels
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
0633477
to
5f12295
Compare
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
5f12295
to
1c57f8e
Compare
Added to the plugin in theforeman/foreman_puppet#12
Added to the plugin in theforeman/foreman_puppet#133
Removes uses of environment from Host
Remove uses of environment from Hostgroup.
Removes uses of Environment from Nic::Managed model
Removes uses of Environment from Report model.
Removes taxation of Environment.
Removes uses of Environment from User. Extraction of `#visible_environments`: theforeman/foreman_puppet#126
Removes uses of Environment in PuppetFactParser and implement plugin guard to import plugin Envrionment if plugin is installed.
Removes Environment related notes from tests, mostly just Host being uselessly provided an environment.
We need to introduce a guard for Environment being present in settings, as we are about to drop Environment. Reimplementation and movement of the Puppet settings is separate commit.
This is completely dropped, in plugin we use factories instead.
We changed the namespace of the plugin to foreman_puppet.
These components are no longer used after puppet has been extracted. This is implemented in theforeman/foreman_puppet#163
ezr-ondrej
force-pushed
the
puppet_extraction
branch
from
dd393ab
to
0205392
Compare
tbrisker
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Thanks @ezr-ondrej and all others involved! Let's see what breaks 😝
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of https://community.theforeman.org/t/making-puppet-optional/17668, please track the following conversations if you don't know why we are extracting and have questions.
I'm opening this for visibility, although it is still missing few bits, but those can go separatelly: