Add puppetmaster to compatibility properties #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theforeman/foreman#8423 we've decided to not safeguard by plugin, but by availability of the `puppetmaster` method. This adds this method to backward compatible properties available on `Host::Managed`.
ezr-ondrej
added
good first issue
|
This is waiting on the core PR to get in. If it gets accepted, this looks great. |
|
This should possibly introduce both |
|
Should be done within #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theforeman/foreman#8423 we've decided to not
safeguard by plugin, but by availability of the
puppetmastermethod.This adds this method to backward compatible properties available on
Host::Managed.