Fix translation infrastructure #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using register_gettext, the initializer should be removed since it'll end up with a duplicate registration. It also failed to update the Makefile so it didn't update the JS locale files. This causes HTTP 404 errors at runtime and missing translations when webpack is used. Fixes: 2ae0ab0 ("Bump version to 0.5.16 with pulling from tx (theforeman#169)")
These files don't have any translations and shouldn't be shipped. Fixes: 0bc1890 ("i18n - extracting new, pulling from tx (theforeman#163)")
chris1984
approved these changes
Sep 18, 2023
|
No, none at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previousy the infrastructure was not set up correctly and didn't include the frontend translation files. While this plugin doesn't use webpack, it did result in HTTP 404 errors at runtime.
cc @adamruzicka