Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation infrastructure #172

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix translation infrastructure #172

merged 3 commits into from
Sep 18, 2023

Commits on Sep 15, 2023

  1. Fix translations infrastructure 

    When using register_gettext, the initializer should be removed since
it'll end up with a duplicate registration. It also failed to update the
Makefile so it didn't update the JS locale files. This causes HTTP 404
errors at runtime and missing translations when webpack is used.

Fixes: 2ae0ab0 ("Bump version to 0.5.16 with pulling from tx (theforeman#169)")
    @ekohl
    ekohl committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f213964 View commit details
    Browse the repository at this point in the history

  2. Remove locales without translations 

    These files don't have any translations and shouldn't be shipped.

Fixes: 0bc1890 ("i18n - extracting new, pulling from tx (theforeman#163)")
    @ekohl
    ekohl committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    dde842e View commit details
    Browse the repository at this point in the history

  3. i18n - pulling from tx

    @ekohl
    ekohl committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0472eb9 View commit details
    Browse the repository at this point in the history