Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables never defined, but used in foreman::puppetmaster #228

Closed
cristifalcas opened this issue Sep 6, 2014 · 3 comments
Closed

Variables never defined, but used in foreman::puppetmaster #228

cristifalcas opened this issue Sep 6, 2014 · 3 comments

Comments

@cristifalcas
Copy link
Contributor

class foreman::puppetmaster (
$foreman_url = $foreman::params::foreman_url,
$foreman_user = $foreman::params::foreman_user,
$foreman_password = $foreman::params::foreman_password,

$foreman::params::foreman_user and $foreman::params::foreman_password are never defined and seems that are also never used
@ekohl
Copy link
Member

ekohl commented Sep 7, 2014

Pretty sure they're used in the template. That they're not defined is fixed in #219.

@cristifalcas
Copy link
Contributor Author

Yes, I see that they are used in a template file. But still, if they don't have default values, they should not be defined as sow.

@ekohl
Copy link
Member

ekohl commented Sep 15, 2014

This has been fixed in 2e42934.

@ekohl ekohl closed this as completed Sep 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekohl @cristifalcas