Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the module update plugins before running rake tasks? #331

Closed
cristifalcas opened this issue Jun 25, 2015 · 3 comments
Closed

should the module update plugins before running rake tasks? #331

cristifalcas opened this issue Jun 25, 2015 · 3 comments

Comments

@cristifalcas
Copy link
Contributor

In init.pp there is this dependency:

  Class['foreman::database']~>
  Foreman::Plugin <| |>

Shouldn't the package first be installed and after that run db::migrate? I think that at least openscap installs files for db::migrate

@domcleal
Copy link
Contributor

I don't remember if there's a specific reason it's that way around. It might have been our unfamiliarity with how plugins would work in practice at the time, or it might be covering up some bugs in how plugins work (i.e. whether you can take a blank DB, activate plugins and db:migrate from scratch without the plugin breaking it).

That said, it works at the moment because all packages for plugins that contain DB migrations or seeds also call them from their post install sections, so installing the package after should perform any necessary steps. (This is to ensure plugin upgrades also migrate DBs etc.)

@mmoll
Copy link
Contributor

mmoll commented Feb 19, 2016

what's the status here?

@cristifalcas
Copy link
Contributor Author

i will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants