Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropsonde telemetry config #838

Merged
merged 2 commits into from
May 20, 2022
Merged

Add dropsonde telemetry config #838

merged 2 commits into from
May 20, 2022
+44 −0

Conversation

teluq-pbrideau
Copy link
Contributor

My fix for #837

ekohl
ekohl approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on my TODO list as well. Very minor suggestion: place the empty line inside the if so there is no diff for Puppetserver < 7.

templates/server/puppetserver/conf.d/puppetserver.conf.erb Outdated Show resolved Hide resolved
@ekohl ekohl enabled auto-merge (squash) May 20, 2022 15:50
@ekohl ekohl linked an issue May 20, 2022 that may be closed by this pull request
Disable Dropsonde telemetry #837
Closed
@ekohl ekohl merged commit 0525815 into theforeman:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable Dropsonde telemetry
3 participants
@teluq-pbrideau @ekohl @theforeman-bot