Add support for 64-bit MAC addresses, fixes #6341 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
lgtm. |
|
There's also a custom MAC validator over at modules/tftp/tftp_api.rb:11, would you mind updating it too please? |
|
@domcleal I've updated the PR to use a valid_mac? method that can be reused in other places (including the tftp_api). I also added a few tests for the Proxy::TFTP::Api class. What's added was just enough to test the MAC address validation and for me to try my hand at Rack unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands validation of MAC addresses to include 64bit MAC addresses. This is related to theforeman/foreman#1470.