Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Kernel#open with File.open #179

Closed
wants to merge 1 commit into from

Conversation

sodabrew
Copy link
Member

@sodabrew sodabrew commented Jul 4, 2014

Kernel#open (the global open method) can be used to open URLs and other interesting things. We don't want that, just the Files please! See http://stackoverflow.com/a/1728941/3483097 for a nice writeup.

@ohadlevy
Copy link
Member

ohadlevy commented Jul 6, 2014

[test]

@domcleal
Copy link
Contributor

Merged as a220e9a for 1.6.0, cheers @sodabrew.

@domcleal domcleal closed this Jul 11, 2014
@sodabrew sodabrew deleted the file_open branch July 23, 2014 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants