fixes #15244 - provide a CNAME api to the DNSCMD provider #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,8 @@ class Api < ::Sinatra::Base | |||
| when 'AAAA' | |||
| ip = IPAddr.new(value, Socket::AF_INET6).to_s | |||
| server.create_aaaa_record(fqdn, ip) | |||
| when 'CNAME' | |||
| server.create_cname_record(fqdn, value) | |||
There was a problem hiding this comment.
We'll need a default implementation for create_cname_record (probably returning an error "This provider doesn't support creation of CNAME records" or something similar), as it's going to take some time for other providers to catch up...
This allows all common DNS operations to be handled from within the Foreman infrastructure. The requirement for assistance from a Microsoft colleague is no longer required.
pikelly
force-pushed
the
feature/15244-add-cname-support
branch
from
b7beb6e
to
9da3a11
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I have added the tests that you requested and the base class methods that call an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to a part of a solution that is used in my organization. There is a rake task that scans all hosts for a cnames host parameter and pushes out these aliases into the Microsoft DHCP servers scattered across the world.
This implementation is not optimal as the collision checks for A, AAAA and CNAME entries should all check for the other types as an A and CNAME entry can collide. I would argue that cname management is an ancillary function so does not need so much attention. In addition the names given to aliases tend to be specialized so will generally not be given to an ordinary machine. The rake task also does additional collision detection to ensure that A and CNAME entries are not already present.