Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18072 - removed load_subnets and load_subnet_data methods from dhcp provider interface #502

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Fixes #18072 - removed load_subnets and load_subnet_data methods from dhcp provider interface #502

merged 1 commit into from
Jan 30, 2017

Conversation

dmitri-d
Copy link
Member

No description provided.

@dmitri-d
Copy link
Member Author

@timogoebel: another PR to fix issues discovered when you were working on support for bonded interfaces.

@dmitri-d dmitri-d mentioned this pull request Jan 30, 2017
Merged
timogoebel
timogoebel reviewed Jan 30, 2017
View reviewed changes
Copy link
Member

@timogoebel timogoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witlessbird : Looks good so far. Just one question inline.

modules/dhcp_libvirt/dhcp_libvirt_main.rb
module Proxy::DHCP::Libvirt
class Provider < ::Proxy::DHCP::Server
attr_reader :libvirt_network, :network

def initialize(network, libvirt_network_impl, subnet_service)
@network = network
@libvirt_network = libvirt_network_impl
@subnet_service_initialized = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer being used; removed.

@dmitri-d
Copy link
Member Author

  • removed unused instance variable @subnet_service_initialized in modules/dhcp_libvirt/dhcp_libvirt_main.rb.

timogoebel
timogoebel approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@timogoebel timogoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witlessbird : Thanks! Looks good to me, improved the API a lot and works great with isc-dhcp. 👍

@timogoebel timogoebel merged commit 0a806f3 into theforeman:develop Jan 30, 2017
@dmitri-d dmitri-d deleted the 18072-remove-load_methods branch January 31, 2017 11:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timogoebel timogoebel timogoebel approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitri-d @timogoebel @theforeman-bot