Fixes some autosign.conf issues (comments, EOL on last line) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,7 @@ def autosign certname | |||
|
|
|||
| # list of hosts which are now allowed to be installed via autosign | |||
| def autosign_list | |||
| File.exist?(autosign_file) ? File.read(autosign_file).split : [] | |||
| File.exist?(autosign_file) ? File.read(autosign_file).split("\n").reject { |v| v =~ /^\s*#.*|^$/ } : [] | |||
There was a problem hiding this comment.
The change to split means trailing spaces aren't stripped any more, perhaps add a .map {|v| v.chomp} or similar?
|
+1 tested OK, with one comment above. |
|
Also, there seem to be no tests for parsing the autosign file? :/ |
|
@vStone thanks. Indeed, contributions welcome! |
…autosign and make sure the autosign file contains a EOL on the last line
|
Added some tests and also fix some other tests that were failing for no good (trivial) reason. |
|
@domcleal mind giving this a go if you have time before puppetcamp? I know I wont :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore commented lines when reading all certificates in autosign and make sure the autosign file contains a EOL on the last line