Refs #34226 - dnscmd nil string error #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
force-pushed
the
dnscmd-argument3
branch
from
bbd391e
to
4401821
Compare
|
Confirmed to be working, tested by the user. Let's merge and I will backport both the fixes to 3.1. |
ekohl
approved these changes
Jan 14, 2022
|
Looks like Rubocop is unhappy, other than that 👍 |
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
lzap
force-pushed
the
dnscmd-argument3
branch
from
4401821
to
c6eb30b
Compare
|
Yeah this is where my terminal wrapped, I remember I was counting key presses to get it right. Well, did not do it. Should be fixed now. Merging, backporting both into 3.1. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a third patch, hopefully a last one. I am keeping this as a Draft until the user confirms it works fine.
Then I will backport no. 2 and 3 into the stable release.
Again: This is untested, I don't have dnscmd setup.