Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing ShNode.reporting_sample_period_s with something else #204

Open
jessicamillar opened this issue Sep 23, 2023 · 0 comments

Comments

@jessicamillar
Copy link
Collaborator

Deserves a design discusion.

sample_period_s for an ShNode (object getting read) / TelemetryName pair: period at which the actor/driver should send a telemetry to Scada.

The issue is, for an actor/driver that reports multiple things, there is not a single such. For example the power meter has this info per node measured/telemetry name pair (in ConfigList/SamplePeriodS for ElectricMeterComponents).

reporting_sample_period_s would be better named default_sample_period_s. Consider doing this and making it the default in scada code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant