Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image Quality Issue across the Website #114

Closed
TheGuyDangerous opened this issue Jan 17, 2024 · 6 comments · Fixed by #117
Closed

Fix Image Quality Issue across the Website #114

TheGuyDangerous opened this issue Jan 17, 2024 · 6 comments · Fixed by #117
Assignees
Labels
approved enhancement New feature or request good first issue Good for newcomers trc-woc Eligible for TRC-WOC event

Comments

@TheGuyDangerous
Copy link
Owner

TheGuyDangerous commented Jan 17, 2024

Describe the issue

Convert every image - up until, Page 13 to

  • A transparent png version of the image.
  • A folder name consisting of the page number, along with the new png format transparent images for the dishes.
  • Convert the image size to under 500kb, with no hit to image resolution.
@TheGuyDangerous TheGuyDangerous added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers trc-woc Eligible for TRC-WOC event labels Jan 17, 2024
@bhavkushwaha
Copy link
Contributor

@TheGuyDangerous I will like to work on this enhancement feature. Please assign this issue to me.

@TheGuyDangerous
Copy link
Owner Author

Go ahead ! @bhavkushwaha

@TheGuyDangerous TheGuyDangerous added assigned and removed help wanted Extra attention is needed labels Jan 17, 2024
@bhavkushwaha
Copy link
Contributor

@TheGuyDangerous I have started the process of converting the already stored images into transparent ones. But some images are of a bit lower quality and upon converting them into png the quality further degrades.
Also when removing the background of some images the main portion is actually not fully in the image so the image after removing the background appears to be cut.

My Solution: The images which do not degrade upon removing the background and converting to png should be kept, and those which have problems should be changed by the better ones.
The below example doesn't look good, so I recomend you to allow me to upload new images which are suitable and appear good after removing the background wherever necessary.

Problem Example Shown Below:

Before: Image with a background
bhel-puri

After: Image after removing the background
bhel-puri-min

@TheGuyDangerous
Copy link
Owner Author

Hi @bhavkushwaha , You can add alternate images instead, with proper plate cutouts, instead of half plate images.

@bhavkushwaha
Copy link
Contributor

Okay Thanks @TheGuyDangerous ,I am proceeding to update the Images Folder and the corresponding code of the webpages.

@bhavkushwaha
Copy link
Contributor

@TheGuyDangerous I have created all the required folders and populated them with the transparent PNG images of all the food item. It was a long process but I hope it is good enough.

@TheGuyDangerous TheGuyDangerous linked a pull request Jan 21, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved enhancement New feature or request good first issue Good for newcomers trc-woc Eligible for TRC-WOC event
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants