Burn auction #143
Open
Burn auction #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidder/bidder.go
Outdated
| logger := log.Logger.With("module", BiddingService) | ||
| bi := &Bidder{} | ||
| bi.BaseService = *core.NewBaseService(logger, BiddingService, bi) | ||
| DB, err := db.NewDB(cfg) |
There was a problem hiding this comment.
do we need db for Bidder? Looks like it is unused.
There was a problem hiding this comment.
ah yes, need to remove, good eye!
| @@ -68,6 +68,9 @@ type Configuration struct { | |||
|
|
|||
| GenesisEth1Block uint64 `mapstructure:"genesis_eth1_block"` | |||
| AppID string `mapstructure:"app_id"` | |||
|
|
|||
| BidAmount uint64 `mapstructure:"bid_amount"` | |||
There was a problem hiding this comment.
I've been looking for the right word for this. What do you think WillingnessToPay?
There was a problem hiding this comment.
Sounds good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128