-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support debug activation events #5645
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
…ug type Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@AlexTugarev please check python extension, all activation events for it should be covered |
…stack/context menu Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
fe204aa
to
5438db3
Compare
Checking with the Python extension right now... |
I see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the Python extension installed the initial loading seems to work nicely. However, after reloading the frontend lots of errors are logged on the backend, see the logs in the details. It doesn't seem to affect the plugins though, at least I couldn't find any obvious issue. logs
|
@AlexTugarev i think you are hitting #5019, i will look at it separately |
I'm going to merge it in the evening if no one objects. |
What it does
onDebug*
activation events, see docs:onDebugAdapterProtocolTracker
in https://code.visualstudio.com/updates/v1_30onDebug*
activation events:*
, before such debug type was not respected cc @tolushadebug/callstack/context
menu actions are passed directly instead of passing them through the global selection serviceHow to test
Hint: you can install and test all extensions together. All plugins (node + test): https://github.com/akosyakov/debug-activation-events/blob/master/plugins.tar
onDebug
: install on-debug-0.0.1.vsix and check thatonDebug
notification appears on any debug activation eventonDebugInitialConfigurations
:onDebugInitialConfigurations
andprovideDebugConfigurations
notifications plus mock debug configuration should be generated dynamicallyonDebugResolve
:onDebugResolve
andresolveDebugConfiguration
notificationsresolveDebugConfiguration
notificationonDebugResolve:<debug type>
:onDebugResolve:node
andresolveDebugConfiguration:node
notificationsonDebugAdapterProtocolTracker
:onDebugAdapterProtocolTracker
andcreateDebugAdapterTracker
notificationsonDebugAdapterProtocolTracker:<debug type>
:onDebugAdapterProtocolTracker:node
andcreateDebugAdapterTracker:node
notificationsReview checklist
Reminder for reviewers