change the size of webview icon

[kpge]

Fixes: #5722

Signed-off-by: kpge gekangping@126.com

[akosyakov]

@kpge How do you test the change?

[kpge]

@kpge How do you test the change?

How to test:

1. git clone the sample
2. cd samples/webview-sample-plugin and perform yarn
3. copy the directory webview-sample-plugin into the plugins folder in Theia
4. start Theia
5. run the command Cat: start
6. move the opened webview widget to different panels (left, right, bottom, main) and verify the icon's size

BTW, the original icon is too small, you can replace it with a bigger icon, I change it to a cat png icon :)

[vince-fugnitto]

It works well for me! :)

I tested using the test sample you mentioned and updated the icon myself as well:

Panel

Sidepanels

I'll give others a chance to review as well.

[akosyakov]

I believe the proper solution is to retrieve icons in the same way as we do in other places of the plugin system, i.e. iconPath should be properly turned into iconUrl by the plugin system, see how it is done for tree view icons

• plugin host part: https://github.com/theia-ide/theia/blob/8c0d234e9c04d9ee37157dc6f66e31645d0de300/packages/plugin-ext/src/plugin/tree/tree-views.ts#L226-L255
• main part: https://github.com/theia-ide/theia/blob/26492e7d6af261be800be6c91d43be39256d59f8/packages/plugin-ext/src/main/browser/view/tree-views-main.tsx#L196-L210

Otherwise we need an additional endpoint to fetch icons for webviews and the code deviate from the standard solution. I would look into this direction, maybe i'm wrong and webviews are special somehow. But If not these code can be simplified to use the proper implementation.

cc @olexii4 @evidolob

[akosyakov]

@kpge @vince-fugnitto please file an issue regardless to my comment to investigate and proceed with merging