Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi file copy #5864

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Conversation

502647092
Copy link
Contributor

@502647092 502647092 commented Aug 6, 2019

What it does

fix #4872 #5856

How to test

  1. Select multi file in navigator
  2. Copy
  3. Select target folder
  4. Paste

temp

Review checklist

Reminder for reviewers

Signed-off-by: MiaoWoo <admin@yumc.pw>
@502647092
Copy link
Contributor Author

@akosyakov
fix multi-file copy

@akosyakov akosyakov added the navigator issues related to the navigator/explorer label Aug 6, 2019
@akosyakov
Copy link
Member

@502647092 please sign ECA: https://www.eclipse.org/legal/ECA.php we cannot proceed without it

thanks for the contribution! testing right now

@akosyakov akosyakov self-requested a review August 6, 2019 07:38
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well, but we cannot merge without ECA.

@502647092
Copy link
Contributor Author

@akosyakov complete

@akosyakov akosyakov merged commit bd04424 into eclipse-theia:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[navigator] copy-paste for multi selection does not work
2 participants